Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeClean] function name #403

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[CodeClean] function name #403

merged 1 commit into from
Oct 5, 2023

Conversation

jaeyun-jung
Copy link
Collaborator

  1. Update ml-remote function name, prefix 'ml_service'.
  2. Hide internal enum and struct.

@jaeyun-jung
[CodeClean] function name
2777123 
1. Update ml-remote function name, prefix 'ml_service'.
2. Hide internal enum and struct.

Signed-off-by: Jaeyun Jung <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 4, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #403. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci
taos-ci approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

songgot
songgot approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anyj0527
anyj0527 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

niley7464
niley7464 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@niley7464 niley7464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaeyun-jung jaeyun-jung merged commit e2ce8b4 into nnstreamer:main Oct 5, 2023
2 checks passed
@jaeyun-jung jaeyun-jung deleted the svc-remote-function-name branch October 5, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@niley7464 niley7464 niley7464 approved these changes

@songgot songgot songgot approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaeyun-jung @taos-ci @anyj0527 @songgot @niley7464