Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of songs that change time signature within song #655

Open
Rdeblock opened this issue Oct 30, 2024 · 9 comments
Open

Handling of songs that change time signature within song #655

Rdeblock opened this issue Oct 30, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@Rdeblock
Copy link

My first experience with Chord Chart Studio so forgive if this is already possible. I've imported the ChordPro version of 10,000 Reasons from Planning Center. The song is in 4/4 but the last line of the verses has a 2/4 measure before returning to 4/4. If I place a period after each of the two chords in this 2/4 measure, the entire (chord) line fails to render properly.

Example:
F.. C.. Gsus. G. C... F/C. C (Result just shows the ChordMark text)

F.. C.. Gsus G C... F/C. C (Results ok except Gsus and G get an entire measure each)

@no-chris
Copy link
Owner

Hello,
Thanks for dropping by and for your messages
That one is easy: https://chordmark.netlify.app/docs/reference/chords#time-signature
Will look into your other messages this Week end
Thanks!

@Rdeblock
Copy link
Author

Rdeblock commented Nov 4, 2024 via email

@no-chris
Copy link
Owner

no-chris commented Nov 6, 2024

Hello,

Second question. Is there a way to insert a comment into the ChordMark "code" and not have it show up in the rendering?

Like comments in the source code for the transcriber only? That is interesting and shouldn't be hard to implement. For me to better understand, what kind of comments would you use it for?

Regarding the first question somehow I think some information was obfuscated in your message? (you may need to look at it in github to see what I mean)

@Rdeblock
Copy link
Author

Rdeblock commented Nov 6, 2024 via email

@Rdeblock
Copy link
Author

Rdeblock commented Nov 7, 2024 via email

@no-chris
Copy link
Owner

no-chris commented Nov 7, 2024

The issue with C.. C.. Csus.. C.. is that it should really be written C Csus.. C..
And then it should render properly

ChordMark does not allow to specify the same chord in the same bar multiple times in a row, the only exception being if the repeating chord is inside a sub-beat, e.g. Am. [Am Am/G] F..

Just for me to understand if that restriction make sense, Is there any reason why you would want to write C.. C.. instead of C?

Let me know if that fixes the second issue?

@Rdeblock
Copy link
Author

Rdeblock commented Nov 7, 2024 via email

@no-chris
Copy link
Owner

no-chris commented Nov 7, 2024

you can use touffi51 on gmail

6/8 works as intended, see no-chris/chord-mark#660 (comment)

but you found indeed an totally unexpected issue which is that the time signature is not detected if there is any extra space after the signature, here you have an extra space after 6/8

it should definitely be more flexible 😱

@no-chris no-chris added the bug Something isn't working label Nov 7, 2024
@Rdeblock
Copy link
Author

Rdeblock commented Nov 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants