-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of songs that change time signature within song #655
Comments
Hello, |
I look forward to your additional answers. Adding two more questions.
According to the User Guide, placing a string of chords with dots to indicate timing should display as follows:
***@***.***
***@***.***
That seems to work if there is a line of lyrics after it. But without those lyrics, it renders as follows (missing measure bars):
***@***.***
What am I missing?
Second question. Is there a way to insert a comment into the ChordMark "code" and not have it show up in the rendering?
Rick
From: Christophe Noël ***@***.***>
Sent: Thursday, October 31, 2024 3:56 PM
To: no-chris/chord-chart-studio ***@***.***>
Cc: Rdeblock ***@***.***>; Author ***@***.***>
Subject: Re: [no-chris/chord-chart-studio] Handling of songs that change time signature within song (Issue #655)
Hello,
Thanks for dropping by and for your messages
That one is easy: https://chordmark.netlify.app/docs/reference/chords#time-signature
Will look into your other messages this Week end
Thanks!
-
Reply to this email directly, view it on GitHub<#655 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMRCZBSCLO27RBBVTGAYNY3Z6KYQZAVCNFSM6AAAAABQ44WUFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJQHE4DMNRWGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hello,
Like comments in the source code for the transcriber only? That is interesting and shouldn't be hard to implement. For me to better understand, what kind of comments would you use it for? Regarding the first question somehow I think some information was obfuscated in your message? (you may need to look at it in github to see what I mean) |
Interesting. I had pasted screenshots into the email. I’ll try to describe it but you know what they say about 1 picture = 1000 words.
In the user guide’s description of Chord duration, the code “A7.. D7.. E7… A7.” Should display as |A7 D7 |E7… A7. |
But for intros, interludes, outros, etc. where there are no lyrics, it doesn’t render that way. I provided the following example:
#Turnaround
Code: C.. C.. Csus.. C..
Renders as:
Turnaround
C.. C.. Csus.. C..
No bar marks and retains the dots. Apparently, thinking it is a comment line, perhaps. I believe it should render as this:
|C C |Csus C |
I would use comments to inform those who look at the ChordMark or ChordPro file. For example, I’m currently using the resulting ChordPro code in SongBookPro. Because that program allows me to establish the sequence of sections independently of the ChordPro code, if the Chorus needs to be played after each verse, I don’t need the Chorus reproduced in the code unless there is some difference. I would like to be able to put a comment telling them that the chorus should be played after each verse so they would know to do that sequencing in SongBookPro.
I hope that makes sense.
Rick
From: Christophe Noël ***@***.***>
Sent: Wednesday, November 6, 2024 1:44 PM
To: no-chris/chord-chart-studio ***@***.***>
Cc: Rdeblock ***@***.***>; Author ***@***.***>
Subject: Re: [no-chris/chord-chart-studio] Handling of songs that change time signature within song (Issue #655)
Hello,
Second question. Is there a way to insert a comment into the ChordMark "code" and not have it show up in the rendering?
Like comments in the source code for the transcriber only? That is interesting and shouldn't be hard to implement. For me to better understand, what kind of comments would you use it for?
Regarding the first question somehow I think some information was obfuscated in your message? (you may need to look at it in github to see what I mean)
—
Reply to this email directly, view it on GitHub<#655 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMRCZBS4N3ACSXYWXXHAISDZ7KERPAVCNFSM6AAAAABQ44WUFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQHA2DGMRTGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
p.s. I forgot to mention that in the exported ChordPro file, these lines are exported as comments. Example:
#i x2
C % Fsus2 %
…exports as:
{start_of_verse: Intro x2}
{c:|C |% |Fsus2 |% |}
{end_of_verse}
I assume fixing the bug will fix this as well but wanted to be sure.
Rick
From: Rick DeBlock
Sent: Wednesday, November 6, 2024 3:34 PM
To: no-chris/chord-chart-studio ***@***.***>; no-chris/chord-chart-studio ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [no-chris/chord-chart-studio] Handling of songs that change time signature within song (Issue #655)
Interesting. I had pasted screenshots into the email. I’ll try to describe it but you know what they say about 1 picture = 1000 words.
In the user guide’s description of Chord duration, the code “A7.. D7.. E7… A7.” Should display as |A7 D7 |E7… A7. |
But for intros, interludes, outros, etc. where there are no lyrics, it doesn’t render that way. I provided the following example:
#Turnaround
Code: C.. C.. Csus.. C..
Renders as:
Turnaround
C.. C.. Csus.. C..
No bar marks and retains the dots. Apparently, thinking it is a comment line, perhaps. I believe it should render as this:
|C C |Csus C |
I would use comments to inform those who look at the ChordMark or ChordPro file. For example, I’m currently using the resulting ChordPro code in SongBookPro. Because that program allows me to establish the sequence of sections independently of the ChordPro code, if the Chorus needs to be played after each verse, I don’t need the Chorus reproduced in the code unless there is some difference. I would like to be able to put a comment telling them that the chorus should be played after each verse so they would know to do that sequencing in SongBookPro.
I hope that makes sense.
Rick
From: Christophe Noël ***@***.******@***.***>>
Sent: Wednesday, November 6, 2024 1:44 PM
To: no-chris/chord-chart-studio ***@***.******@***.***>>
Cc: Rdeblock ***@***.******@***.***>>; Author ***@***.******@***.***>>
Subject: Re: [no-chris/chord-chart-studio] Handling of songs that change time signature within song (Issue #655)
Hello,
Second question. Is there a way to insert a comment into the ChordMark "code" and not have it show up in the rendering?
Like comments in the source code for the transcriber only? That is interesting and shouldn't be hard to implement. For me to better understand, what kind of comments would you use it for?
Regarding the first question somehow I think some information was obfuscated in your message? (you may need to look at it in github to see what I mean)
—
Reply to this email directly, view it on GitHub<#655 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMRCZBS4N3ACSXYWXXHAISDZ7KERPAVCNFSM6AAAAABQ44WUFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQHA2DGMRTGE>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
The issue with ChordMark does not allow to specify the same chord in the same bar multiple times in a row, the only exception being if the repeating chord is inside a sub-beat, e.g. Just for me to understand if that restriction make sense, Is there any reason why you would want to write Let me know if that fixes the second issue? |
My apology. You are correct, of course. My bad. However, the problem is real but I now realize perhaps only in certain unusual time signatures. Here’s the song where I experienced the problem. It’s in 6/8.
From Plead the Blood
#i x2
6/8
C... C/E... F C/E... C/G... F
Renders identically to the above
#u
C... C/E... F C/E... C/G... F
I plead the _blood
Similarly, this renders identically to the source except the underscore is omitted.
As long as I give full measures to a chord it renders fine. But as soon as I add dots to define rhythm, it doesn’t see it as a chord line. I’m going to attach the Chordmark source here but it may get lost in github. I couldn’t find a way to save the Chordmark source to a file so have sent screenshots. The first shows what I think the source should be (but that renders incorrectly). The second is after I compensated for this problem to get output that I want.
***@***.***
***@***.***
If you provide me with a non-github email address, I can send again.
Rick
From: Christophe Noël ***@***.***>
Sent: Thursday, November 7, 2024 12:44 PM
To: no-chris/chord-chart-studio ***@***.***>
Cc: Rdeblock ***@***.***>; Author ***@***.***>
Subject: Re: [no-chris/chord-chart-studio] Handling of songs that change time signature within song (Issue #655)
The issue with C.. C.. Csus.. C.. is that it should really be written C Csus.. C..
And then it should render properly
ChordMark does not allow to specify the same chord multiple times in a row, the only exception being if the repeating chord is inside a sub-beat, e.g. Am. [Am Am/G] F..
Just for me to understand if that restriction make sense, Is there any reason why you would want to write C.. C.. instead of C?
Let me know if that fixes the second issue?
—
Reply to this email directly, view it on GitHub<#655 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMRCZBQPXRY4BSBLG4FL34DZ7PGITAVCNFSM6AAAAABQ44WUFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTGE3TKMRVHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
you can use touffi51 on gmail 6/8 works as intended, see no-chris/chord-mark#660 (comment) but you found indeed an totally unexpected issue which is that the time signature is not detected if there is any extra space after the signature, here you have an extra space after it should definitely be more flexible 😱 |
Though not ideal, I can work with that. Thanks
From: Christophe Noël ***@***.***>
Sent: Thursday, November 7, 2024 2:05 PM
To: no-chris/chord-chart-studio ***@***.***>
Cc: Rdeblock ***@***.***>; Author ***@***.***>
Subject: Re: [no-chris/chord-chart-studio] Handling of songs that change time signature within song (Issue #655)
you can use touffi51 on gmail
6/8 works as intended, see no-chris/chord-mark#660 (comment)<no-chris/chord-mark#660 (comment)>
but you found indeed an totally unexpected issue which is that the time signature is not detected if there is any extra space after the signature, here you have an extra space after 6/8
it should definitely be more flexible 😱
—
Reply to this email directly, view it on GitHub<#655 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMRCZBWV2VJSZMWES7KJAFTZ7PP2RAVCNFSM6AAAAABQ44WUFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTGMZDEMJVHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
My first experience with Chord Chart Studio so forgive if this is already possible. I've imported the ChordPro version of 10,000 Reasons from Planning Center. The song is in 4/4 but the last line of the verses has a 2/4 measure before returning to 4/4. If I place a period after each of the two chords in this 2/4 measure, the entire (chord) line fails to render properly.
Example:
F.. C.. Gsus. G. C... F/C. C (Result just shows the ChordMark text)
F.. C.. Gsus G C... F/C. C (Results ok except Gsus and G get an entire measure each)
The text was updated successfully, but these errors were encountered: