Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unit test example #329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stwissel
Copy link

@Stwissel Stwissel commented Nov 9, 2023

Got confused why unit test didn't work, learned the documentation is outdated.
I'd like to save others that learning experience :-)

Fixes #328

(formatting changes by pretttierJS sorry - hope it isn't an issue)

(formatting cganges by pretttier)
Copy link

linux-foundation-easycla bot commented Nov 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Stwissel
Copy link
Author

@knolleary - merge this?

@dceejay
Copy link
Member

dceejay commented Oct 23, 2024

Hi - sorry - there seem to be lots of formatting changes that aren't actual changes - That make it hard to spot the real changes... any chance you can undo them ?

@knolleary
Copy link
Member

TBH, no problem with the formatting changes - they are all sensible. The bit that caused me to pause previously was adding node-red as a full dev dependency. That doesn't feel optimal, but I'm not sure how to describe the alternatives better in the docs. Will noodle on it some more.

@Stwissel
Copy link
Author

I'm curious. The test helper depends on nodeRED. How to get around it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit testing sample code doesn't match test-helper
3 participants