Diag WG Meeting - 2017-05-11

[joshgav]

Date/Time

Thursday May 11 1900 UTC (click for your local time)

It's helpful if you give this post a 👍 or 👎 so we know you'd like to attend.

Join/Watch

If you are only observing please use the YouTube channel; Hangouts limits the number of connections.

• Watch on YouTube: https://www.youtube.com/watch?v=YTlL1MsLbZw
• Participate on Hangouts: https://hangouts.google.com/hangouts/_/ytl/OCBtRQ90FgFAp6tRYTH0nBfe6wLn04ULejYe3lnHNyk=?eid=100598160817214911030&hl=en_US&authuser=0

If the Hangouts link isn't working for you try removing the query string (the ? and all which follows).

Minutes

• Minutes: https://docs.google.com/document/d/1pbsM1nhwcZcDpi9Dff7ngkoYgPTyBQVPfD0TPbACxpc

Agenda

Issues tagged diag-agenda across the nodejs GitHub organization.

nodejs/node

• build: require --without-debugger explicitly #12768
• Uniform way to trigger debugger on first line #12630
• inspector: JavaScript bindings for the inspector #12263
• Missing async callstacks on setTimeout #11370

nodejs/diagnostics

• Node.js Collaboration Summit diagnostics discussion minutes #95
• [docs] requesting comments on diagnostics-howtos project #92
• [trace event] tracking issue #84
• [async_hooks] tracking issue #29

/cc @nodejs/diagnostics @nodejs/post-mortem

[joshgav]

In fact per #90 the meeting should be today but I'm proposing we have it next week instead, yes? The delayed release of Node 8 affords us some time to think about related diagnostic items so let's take advantage of that.

I'll fill in the blanks above by early next week. Thank you!

[ofrobots]

I'm OOO next week and won't be able to attend.

[joshgav]

Updated the agenda with current diag-agenda items and added minutes doc and YouTube/Hangouts. Will post link to Hangouts at 12 to try to avoid past problems ;).

Agenda copied here for your convenience:

nodejs/node

• Uniform way to trigger debugger on first line #12630
• inspector: JavaScript bindings for the inspector #12263

nodejs/diagnostics

• [docs] requesting comments on diagnostics-howtos project #92
• fixed monthly schedule for Diag WG meetings #90
• [trace event] tracking issue #84
• [async_hooks] tracking issue #29

[AndreasMadsen]

It is too late for me, 11 PM locally and I need to get up early.

The async_hooks update is that Trevor has made a PR nodejs/node#11883, currently they are investigating some test failures. The PR does not include the Embedder API and PromiseHooks integration. The Embedder API will appear in a future PR, I don't know about PromiseHooks. I should also review it, but I'm quite busy these days.

There has been a feature request for supporting "Async Callstacks" in the Inspector. This requires some glue between async_hooks and --inspect, see: nodejs/node#11370.

[matthewloring]

Just as an fyi, I have put together a patch for promise hook support on top of nodejs/node#11883. Not completely done but I won't be able to open it until the current async hooks work lands in any case. WIP patch here: https://github.com/matthewloring/node/commit/dd178336a60c2698619b96a62267bd528c09ae0d.

[jkrems]

I have conflicting meetings and won't be able to make it.

[joshgav]

We at Microsoft have been working on something to make it easier for APM-like projects to share implementations of instrumentation patches for third-party modules and would like to share it with y'all for thoughts, but it's not quite ready yet.

Otherwise I've been heads down with internal work of late and have no updates at the moment.

If it'll just be @matthewloring and I today, perhaps we're better off postponing for a week or two till @ofrobots is back and I can share more on the above?

[mhdawson]

The meeting is 2 hours from now right ?

[mhdawson]

Just checking because I'm just a bit confused. Earlier I thought it was now, but looking at 21 UTC I think its 2 hours later than I thought and looking at the hangout I think it shows a different time.

[joshgav]

@mhdawson Oh, oops... It seems it is according to the original post! In the Foundation calendar it has the wrong time, I'll update now.

But I can't make 2pm Pacific. Can someone else lead this meeting today? Or can we postpone to Thursday 5/11 and make it a few hours earlier to better accommodate Europeans?

[mhdawson]

5/11 would be ok with me

[matthewloring]

5/11 is good for me too

[joshgav]

let's bump it then to 5/11. thanks all!

[watson]

I'm happy to see that aysnc_hooks is on the agenda. I'd love to have a talk on the meeting about how close we are to landing it and if there's any chance we can have something - even experimental - in Node.js v8.0. And if that's too optimistic, then how soon after 8.0 we can land it.

[joshgav]

Updated agenda:

nodejs/node

• build: require --without-debugger explicitly #12768
• Uniform way to trigger debugger on first line #12630
• inspector: JavaScript bindings for the inspector #12263
• Missing async callstacks on setTimeout #11370

nodejs/diagnostics

• Node.js Collaboration Summit diagnostics discussion minutes #95
• [docs] requesting comments on diagnostics-howtos project #92
• [trace event] tracking issue #84
• [async_hooks] tracking issue #29

[AndreasMadsen]

FYI: there is quite a lot to cover regarding async_hooks. I have inserted my talking notes in the minutes section.

[watson]

The date on the "Watch on YouTube" link is wrong. Currently says 2017-04-27. Is that the wrong link or just the wrong date?

[sam-github]

Can I join or observe this meeting? And this Working Group? I'm not sure how formal its membership is. I'm starting to look at inspector and async_hooks wrt. how we can use them and will start to be more involved, I've been mostly watching so far.

[watson]

@sam-github absolutely. Just open an PR similar to #28 adding yourself to the list in the README.md

[AndreasMadsen]

Can I join or observe this meeting?

Shouldn't be a problem, the hangout is usually open to everyone and I don't think we will hit the participants limit.

[joshgav]

Updated the date on the YouTube link, thanks @watson.

Hangouts link is https://hangouts.google.com/hangouts/_/ytl/OCBtRQ90FgFAp6tRYTH0nBfe6wLn04ULejYe3lnHNyk=?eid=100598160817214911030&hl=en_US&authuser=0

[watson]

@sam-github you should be able to join now?

[sam-github]

Yes, and it turns out I'm already in the README as a member https://github.com/nodejs/diagnostics/blob/master/README.md#members (I guess I've been delinquent).

[AndreasMadsen]

If the async_hooks tracking issue is missing something just edit and comment: #29

[watson]

It seems like we ran out space in the Hangouts so @naugtur could not join this time 😞 This was a little unfortunate as his issue #92 was actually on the agenda. Is there any way to avoid this in the future? I don't know if Hangouts have a version with room for more than 10 people

[naugtur]

It's ok, I need to catch up on this repo, still looking into what I want to write there about async hooks. I'll try not to be late next time ;)

If hangout is hosted by a member of a paying org, the limit is 15 AFAIK.

[joshgav]

notes in #97