Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we extend jenkins-alerts to release machines? #3414

Open
UlisesGascon opened this issue Jul 7, 2023 · 11 comments · May be fixed by nodejs/jenkins-alerts#262
Open

Should we extend jenkins-alerts to release machines? #3414

UlisesGascon opened this issue Jul 7, 2023 · 11 comments · May be fixed by nodejs/jenkins-alerts#262

Comments

@UlisesGascon
Copy link
Member

I was thinking that currently we are only tracking the machines under ci.nodejs.org, but this is limited to the test machines. Should we extended it to the release machines?

@richardlau
Copy link
Member

+1. FWIW our orka macOS release machines are currently all offline #3416

@UlisesGascon
Copy link
Member Author

I can create a PR for it, but I will need help to generate a valid token and also to add it in the repository secrets.

@richardlau
Copy link
Member

I can create a PR for it, but I will need help to generate a valid token and also to add it in the repository secrets.

Hmm actually that's a good point. Do we remember which Jenkins user we're using? If it's one of the build automation GH users it won't have access to the release Cl.

@richardlau richardlau changed the title Should we extend jenkins-alerts to relese machines? Should we extend jenkins-alerts to release machines? Jul 7, 2023
@UlisesGascon
Copy link
Member Author

Hmm actually that's a good point. Do we remember which Jenkins user we're using? If it's one of the build automation GH users it won't have access to the release Cl.

Currently, I think it is using a personal token from my account on ci.nodejs.org, as it is the one that I used when building the project before it was transferred to Node.js.

@UlisesGascon UlisesGascon self-assigned this Jul 7, 2023
@richardlau
Copy link
Member

hmm. FWIW @UlisesGascon I sent an email to the other members of @nodejs/build-infra today suggesting we upgrade your level of access. Although maybe we ought to be setting up the automation with one of our Build WG-owned automation accounts.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Jul 7, 2023

hmm. FWIW @UlisesGascon I sent an email to the other members of https://github.com/orgs/nodejs/teams/build-infra today suggesting we upgrade your level of access.

Thanks! :)

Although maybe we ought to be setting up the automation with one of our Build WG-owned automation accounts.

Yes, 100 we should replace the current token for a one generated by a Build WG-owned automation accounts and keep the token in the secrets repo as well.

I created a PR nodejs/jenkins-alerts#262 for the changes.

@UlisesGascon
Copy link
Member Author

@richardlau should I use @nodejs-ci account to generate the tokens?

@richardlau
Copy link
Member

@UlisesGascon I can't remember if that account has access to Jenkins (either one). I think it's used by our Jenkins jobs to check code out of GitHub.

@richardlau
Copy link
Member

richardlau commented Jul 12, 2023

@UlisesGascon @node-forward-build might be a better account to use, depending on whether we can create API tokens with less access than the user has.

@richardlau
Copy link
Member

If Jenkins doesn't support restricted API tokens, we may have to use another account (such as @nodejs-ci) and get that account added to both Jenkins with minimum read-only permissions.

Copy link

github-actions bot commented May 8, 2024

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants