Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to handle HPE_PAUSED_H2_UPGRADE on upgrade to http2 ? #522

Open
TrekkieCoder opened this issue Oct 21, 2024 · 1 comment
Open

How to handle HPE_PAUSED_H2_UPGRADE on upgrade to http2 ? #522

TrekkieCoder opened this issue Oct 21, 2024 · 1 comment

Comments

@TrekkieCoder
Copy link

The README mentions how to handle HPE_PAUSED_UPGRADE but not HPE_PAUSED_H2_UPGRADE. What should be done to handle this ?
@ShogunPanda
Copy link
Contributor

Hi!
You are totally right. HPE_PAUSED_H2_UPGRADE should be handle exactly as HPE_PAUSED_UPGRADE: the parser will return one of those errors codes accordingly to the headers and then pause. Afterwards it can only be unpaused with llhttp_resume_after_upgrade.

Would you be open to send a PR to fix the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShogunPanda @TrekkieCoder