diff --git a/.github/workflows/build-tarball.yml b/.github/workflows/build-tarball.yml index 56236ced367c19..f712cc8dca2090 100644 --- a/.github/workflows/build-tarball.yml +++ b/.github/workflows/build-tarball.yml @@ -36,6 +36,16 @@ permissions: jobs: build-tarball: + needs: + - lint-addon-docs + - lint-cpp + - lint-js-and-md + - lint-py + - lint-yaml + - lint-sh + - lint-codeowners + - lint-pr-url + if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 3c7012017df7d9..5731d3e7c7c4a4 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -31,6 +31,16 @@ permissions: jobs: build-windows: + needs: + - lint-addon-docs + - lint-cpp + - lint-js-and-md + - lint-py + - lint-yaml + - lint-sh + - lint-codeowners + - lint-pr-url + if: github.event.pull_request.draft == false strategy: matrix: diff --git a/.github/workflows/coverage-linux-without-intl.yml b/.github/workflows/coverage-linux-without-intl.yml index f6c47f92e341c5..1bc3b16f6819db 100644 --- a/.github/workflows/coverage-linux-without-intl.yml +++ b/.github/workflows/coverage-linux-without-intl.yml @@ -38,6 +38,16 @@ permissions: jobs: coverage-linux-without-intl: + needs: + - lint-addon-docs + - lint-cpp + - format-cpp + - lint-js-and-md + - lint-py + - lint-yaml + - lint-sh + - lint-codeowners + - lint-pr-url if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: diff --git a/.github/workflows/coverage-linux.yml b/.github/workflows/coverage-linux.yml index 054b98cfe72e92..a312c0ce29629b 100644 --- a/.github/workflows/coverage-linux.yml +++ b/.github/workflows/coverage-linux.yml @@ -38,6 +38,16 @@ permissions: jobs: coverage-linux: + needs: + - lint-addon-docs + - lint-cpp + - format-cpp + - lint-js-and-md + - lint-py + - lint-yaml + - lint-sh + - lint-codeowners + - lint-pr-url if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: diff --git a/.github/workflows/coverage-windows.yml b/.github/workflows/coverage-windows.yml index 366a5fc344c341..c0398b52bbec5a 100644 --- a/.github/workflows/coverage-windows.yml +++ b/.github/workflows/coverage-windows.yml @@ -38,6 +38,18 @@ permissions: jobs: coverage-windows: + needs: + - lint-addon-docs + - lint-cpp + - format-cpp + - lint-js-and-md + - lint-py + - lint-yaml + - lint-sh + - lint-codeowners + - lint-pr-url + - build-windows + if: github.event.pull_request.draft == false runs-on: windows-2022 steps: diff --git a/.github/workflows/doc.yml b/.github/workflows/doc.yml index 36715798829efb..3584c6f39d65d1 100644 --- a/.github/workflows/doc.yml +++ b/.github/workflows/doc.yml @@ -21,6 +21,9 @@ permissions: jobs: build-docs: + needs: + - build-tarball + if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index ff01e442990582..d7504e111213df 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -22,6 +22,7 @@ permissions: jobs: lint-addon-docs: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -37,6 +38,7 @@ jobs: - name: Lint addon docs run: NODE=$(command -v node) make lint-addon-docs lint-cpp: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -52,6 +54,9 @@ jobs: - name: Lint C/C++ files run: make lint-cpp format-cpp: + needs: + - lint-commit-message + - lint-cpp if: ${{ github.event.pull_request && github.event.pull_request.draft == false && github.base_ref == github.event.repository.default_branch }} runs-on: ubuntu-latest steps: @@ -90,6 +95,7 @@ jobs: exit "$EXIT_CODE" fi lint-js-and-md: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -115,6 +121,7 @@ jobs: env: NODE_RELEASED_VERSIONS: ${{ steps.get-released-versions.outputs.NODE_RELEASED_VERSIONS }} lint-py: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -132,6 +139,7 @@ jobs: make lint-py-build make lint-py lint-yaml: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -150,6 +158,7 @@ jobs: make lint-yaml lint-sh: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -160,6 +169,7 @@ jobs: - name: Lint Shell scripts run: tools/lint-sh.mjs . lint-codeowners: + needs: lint-commit-message if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: @@ -170,6 +180,7 @@ jobs: with: checks: files,duppatterns lint-pr-url: + needs: lint-commit-message if: ${{ github.event.pull_request }} runs-on: ubuntu-latest steps: diff --git a/.github/workflows/test-asan.yml b/.github/workflows/test-asan.yml index 3b869140e39317..61e05d701810d7 100644 --- a/.github/workflows/test-asan.yml +++ b/.github/workflows/test-asan.yml @@ -38,6 +38,7 @@ permissions: jobs: test-asan: + needs: build-tarball if: github.event.pull_request.draft == false runs-on: ubuntu-20.04 env: diff --git a/.github/workflows/test-internet.yml b/.github/workflows/test-internet.yml index 20a3beb5367e7e..0354d3cca6a5c0 100644 --- a/.github/workflows/test-internet.yml +++ b/.github/workflows/test-internet.yml @@ -37,6 +37,7 @@ permissions: jobs: test-internet: + needs: build-tarball if: github.repository == 'nodejs/node' || github.event_name != 'schedule' runs-on: ubuntu-latest steps: diff --git a/.github/workflows/test-linux.yml b/.github/workflows/test-linux.yml index c5838f316c9662..22d023d76d2379 100644 --- a/.github/workflows/test-linux.yml +++ b/.github/workflows/test-linux.yml @@ -31,6 +31,7 @@ permissions: jobs: test-linux: + needs: build-tarball if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index d0d9d846156dee..a1428236990f68 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -37,6 +37,7 @@ permissions: jobs: test-macOS: + needs: build-tarball if: github.event.pull_request.draft == false runs-on: macos-latest steps: