Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a native support of Argon2 hashing algorithm #34452

Closed
pubmikeb opened this issue Jul 20, 2020 · 10 comments
Closed

Add a native support of Argon2 hashing algorithm #34452

pubmikeb opened this issue Jul 20, 2020 · 10 comments
Labels
crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js.

Comments

@pubmikeb
Copy link

Is your feature request related to a problem? Please describe.
Currently Node.js provides a native support of scrypt, which is good but isn't the most secure option.

Describe the solution you'd like
It would be great to have a native support of argon2 via crypto module, just like scrypt has nowadays.

Describe alternatives you've considered
An argon2 npm module for Node.js.

@pubmikeb pubmikeb changed the title Add native support of Argon2 hashing algorithm Add a native support of Argon2 hashing algorithm Jul 20, 2020
@bnoordhuis bnoordhuis added crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js. labels Jul 21, 2020
@bnoordhuis
Copy link
Member

openssl/openssl#4091 - until openssl adds support for it, there's nothing actionable for Node.js.

I'm going to close this for now but it can be reopened once upstream support materializes.

@gurgunday
Copy link
Contributor

Hey everyone! The PR that introduces argon2 support is pretty close to being merged. I think we can re-open this issue.

@bnoordhuis
Copy link
Member

We can do that when we upgrade to an openssl release that supports it.

@jonnytest1
Copy link

jonnytest1 commented Apr 12, 2023

openssl merged the argon2 api last month \o/

@gurgunday
Copy link
Contributor

Yeah, but AFAIK they haven’t made a release with it yet

@codepunkt
Copy link

codepunkt commented Dec 12, 2023

OpenSSL 3.2.0 has support for ArgonId. Let's reopen and start by switching to that OpenSSL release 😁

@franciscop
Copy link

franciscop commented Jun 2, 2024

I'm trying to find info on how to use the OpenSSL integration with Node for ArgonId hashing, any tip here? Or is it not available/exposed yet from OpenSSL to the Node API? Or is OpenSSL 3.2 not supported yet?

What I've tried:

  • Googling for "argon2 site:nodejs.org/api/", "argonId site:nodejs.org/api/", etc yielded no results.
  • Checking the exports of crypto, I can see it has scrypt but no mention of argon2 or argonId or just argon in the file at all.

Tried also to just specify the hashing algorithm, but that also didn't work (I tried multiple possible variations):

import { createHash } from "node:crypto";
const hash = createHash("argon2");  // argon2id, argon2Id, argonId2, etc
// Digest method not supported

(at this point and after reading many Github threads, I believe there's no support yet, but wanted to double check here)

@codepunkt
Copy link

/cc @bnoordhuis 😀

@WooMai
Copy link

WooMai commented Dec 24, 2024

OpenSSL has been supported argon2 for over a year. When can we have native argon2 support in Node.js?

@franciscop
Copy link

For those interested, seems like progress is now happening here:

#50353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

7 participants