Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request from nodejs/help] ESM Caching #52961

Closed
avivkeller opened this issue May 12, 2024 · 2 comments
Closed

[Feature Request from nodejs/help] ESM Caching #52961

avivkeller opened this issue May 12, 2024 · 2 comments
Labels
discuss Issues opened for discussions and feedbacks. esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js.

Comments

@avivkeller
Copy link
Member

During its four years of existence, nodejs/help#2806 has gained significant attention. Therefore, I'm bringing it to this repository for potential review and implementation.

It revolves around the idea of an ESM cache, similar to the one in CommonJS.

Given the traction it has received, I believe it's worth discussing.

@avivkeller avivkeller added discuss Issues opened for discussions and feedbacks. feature request Issues that request new features to be added to Node.js. esm Issues and PRs related to the ECMAScript Modules implementation. labels May 12, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 12, 2024

Duplicate of #45206

There's already an ESM cache, and it cannot be exposed. All use cases should be covered by the Hooks API – if not let's open an issue describing such use case.

@aduh95 aduh95 closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2024
@simlu
Copy link

simlu commented May 13, 2024

Duplicate of #45206

There's already an ESM cache, and it cannot be exposed. All use cases should be covered by the Hooks API – if not let's open an issue describing such use case.

The use case is:

  • Running tests while hot reloading code without causing memory leaks.

I've documented the current workaround (that causes memory leaks) here.

Would you like me to open a ticket for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issues opened for discussions and feedbacks. esm Issues and PRs related to the ECMAScript Modules implementation. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

3 participants