Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/nodejs/node/pull/54677 should be backported to NodeJS 20 Branch #55726

Open
alexsch01 opened this issue Nov 5, 2024 · 2 comments

Comments

@alexsch01
Copy link
Contributor

alexsch01 commented Nov 5, 2024

Version

v20.18.0

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

This #54677 is not implemented in v20.18.0
v18.20.4 and v22.11.0 (other LTS) versions have console.error not red

How often does it reproduce? Is there a required condition?

Every time

What is the expected behavior? Why is that the expected behavior?

This #54677 should be implemented for v20.x
same behavior as v18.20.4 and v22.11.0 (other LTS) versions

What do you see instead?

console.error is red in v20.18.0

node -e "console.error(process.version)"

is v20.18.0 and red

Additional information

The code that should be reverted first appeared in NodeJS 20 branch in v20.15.0

@alexsch01 alexsch01 changed the title Revert https://github.com/nodejs/node/pull/54677 in NodeJS 20 Branch Backport https://github.com/nodejs/node/pull/54677 to NodeJS 20 Branch Nov 5, 2024
@alexsch01 alexsch01 changed the title Backport https://github.com/nodejs/node/pull/54677 to NodeJS 20 Branch https://github.com/nodejs/node/pull/54677 should be backported to NodeJS 20 Branch Nov 5, 2024
@avivkeller
Copy link
Member

avivkeller commented Nov 5, 2024

SGTM, just gotta wait for the next LTS release, and if it's not clean, open a backport PR

This was referenced Nov 5, 2024
Closed
Closed
@avivkeller
Copy link
Member

Fixed by #55879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants