build: use variable for simdutf path #56196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
build
zcbenz
approved these changes
Dec 10, 2024
codebytere
force-pushed
the
simdutf-path-gn
branch
from
b0ed5da to
2a98409
Compare
lpinca
approved these changes
Dec 10, 2024
jasnell
approved these changes
Dec 11, 2024
codebytere
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a1d980c |
targos
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56196 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #55928 - as of https://chromium-review.googlesource.com/c/chromium/src/+/6054817 Chromium includes simdutf and so there's a conflict if both are used. This allows customizing the one Node.js uses so Electron can use Chromium's in Node.js