Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-12-19, Version 23.5.0 (Current) #56310

Open
wants to merge 88 commits into
base: v23.x
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 18, 2024

WebCryptoAPI Ed25519 and X25519 algorithms are now stable

Following the merge of Curve25519 into the
Web Cryptography API Editor's Draft the
Ed25519 and X25519 algorithm identifiers are now stable and will no longer
emit an ExperimentalWarning upon use.

Contributed by Filip Skokan in #56142.

On-thread hooks are back

This release introduces module.registerHooks() for registering module loader
customization hooks that are run for all modules loaded by require(), import
and functions returned by createRequire() in the same thread, which makes them
easier for CJS monkey-patchers to migrate to.

import assert from 'node:assert';
import { registerHooks, createRequire } from 'node:module';
import { writeFileSync } from 'node:fs';

writeFileSync('./bar.js', 'export const id = 123;', 'utf8');

registerHooks({
  resolve(specifier, context, nextResolve) {
    const replaced = specifier.replace('foo', 'bar');
    return nextResolve(replaced, context);
  },
  load(url, context, nextLoad) {
    const result = nextLoad(url, context);
    return {
      ...result,
      source: result.source.toString().replace('123', '456'),
    };
  },
});

// Checks that it works with require.
const require = createRequire(import.meta.url);
const required = require('./foo.js');  // Redirected by resolve hook to bar.js
assert.strictEqual(required.id, 456);  // Replaced by load hook to 456

// Checks that it works with import.
const imported = await import('./foo.js');  // Redirected by resolve hook to bar.js
assert.strictEqual(imported.id, 456);  // Replaced by load hook to 456

This complements the module.register() hooks - the new hooks fit better
internally and cover all corners in the module graph; whereas
module.register() previously could not cover require() while it was
on-thread, and still cannot cover createRequire() after being moved
off-thread.

They are also run in the same thread as the modules being loaded and where the
hooks are registered, which means they are easier to debug (no more
console.log() getting lost) and do not have the many deadlock issues haunting
the module.register() hooks. The new API also takes functions directly so that
it's easier for intermediate loader packages to take user options from files
that the hooks can't be aware of, like many existing CJS monkey-patchers do.

Contributed by Joyee Cheung in #55698.

Other notable changes

  • [59cae91465] - (SEMVER-MINOR) dgram: support blocklist in udp (theanarkh) #56087
  • [72f79b44ed] - doc: stabilize util.styleText (Rafael Gonzaga) #56265
  • [b5a2c0777d] - (SEMVER-MINOR) module: add prefix-only modules to module.builtinModules (Jordan Harband) #56185
  • [9863d27566] - (SEMVER-MINOR) module: only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194
  • [8e780bc5ae] - (SEMVER-MINOR) module: use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
  • [65bc8e847f] - (SEMVER-MINOR) report: fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068
  • [0ab36e1937] - (SEMVER-MINOR) sqlite: aggregate constants in a single property (Edigleysson Silva (Edy)) #56213
  • [efcc5d90c5] - (SEMVER-MINOR) src,lib: stabilize permission model (Rafael Gonzaga) #56201
Commits
  • [2314e4916e] - assert: make Maps be partially compared in partialDeepStrictEqual (Giovanni Bucci) #56195
  • [cfbdff7b45] - assert: make partialDeepStrictEqual work with ArrayBuffers (Giovanni Bucci) #56098
  • [f264dd6d20] - buffer: document concat zero-fill (Duncan) #55562
  • [4831b87d83] - build: set DESTCPU correctly for 'make binary' on loongarch64 (吴小白) #56271
  • [1497bb405e] - build: fix missing fp16 dependency in d8 builds (Joyee Cheung) #56266
  • [445c8c7489] - build: add major release action (Rafael Gonzaga) #56199
  • [f4faedfa69] - build: fix C string encoding for PRODUCT_DIR_ABS (Anna Henningsen) #56111
  • [6f49c8006c] - build: use variable for simdutf path (Shelley Vohr) #56196
  • [fcaa2c82a6] - build: fix GN build on macOS (Joyee Cheung) #56141
  • [08e5309f4f] - Revert "build: avoid compiling with VS v17.12" (Gerhard Stöbich) #56151
  • [c2fb38cfdf] - crypto: graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142
  • [8658833884] - deps: update nghttp3 to 1.6.0 (Node.js GitHub Bot) #56258
  • [7c941d4610] - deps: update simdutf to 5.6.4 (Node.js GitHub Bot) #56255
  • [4e9113eada] - deps: update libuv to 1.49.2 (Luigi Pinca) #56224
  • [db6aba12e4] - deps: update c-ares to v1.34.4 (Node.js GitHub Bot) #56256
  • [25bb462bc2] - deps: define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #56238
  • [54308c51bb] - deps: update sqlite to 3.47.2 (Node.js GitHub Bot) #56178
  • [59cae91465] - (SEMVER-MINOR) dgram: support blocklist in udp (theanarkh) #56087
  • [52c18e605e] - doc: fix color contrast issue in light mode (Rich Trott) #56272
  • [72f79b44ed] - doc: stabilize util.styleText (Rafael Gonzaga) #56265
  • [0d08756d0c] - doc: clarify util.aborted resource usage (Kunal Kumar) #55780
  • [f94f21080b] - doc: add esm examples to node:repl (Alfredo González) #55432
  • [7a10ef88d9] - doc: add esm examples to node:readline (Alfredo González) #55335
  • [cc7a7c391b] - doc: fix 'which' to 'that' and add commas (Selveter Senitro) #56216
  • [c5b086250e] - doc: fix winget config path (Alex Yang) #56233
  • [71c38a24d4] - doc: add esm examples to node:tls (Alfredo González) #56229
  • [394fffbbde] - doc: add esm examples to node:perf_hooks (Alfredo González) #55257
  • [7b2a6ee61e] - doc: sea.getRawAsset(key) always returns an ArrayBuffer (沈鸿飞) #56206
  • [8092dcf27e] - doc: update announce documentation for releases (Rafael Gonzaga) #56200
  • [2974667815] - doc: update blog link to /vulnerability (Rafael Gonzaga) #56198
  • [f3b3ff85e0] - doc: call out import.meta is only supported in ES modules (Anton Kastritskii) #56186
  • [a9e67280e7] - doc: add ambassador message - benefits of Node.js (Michael Dawson) #56085
  • [e4922ab15f] - doc: fix incorrect link to style guide (Yuan-Ming Hsu) #56181
  • [114a3e5a05] - doc: fix c++ addon hello world sample (Edigleysson Silva (Edy)) #56172
  • [f1c2d2f65e] - doc: update blog release-post link (Ruy Adorno) #56123
  • [d48b5224c0] - doc: fix module.md headings (Chengzhong Wu) #56131
  • [4cc0493a0b] - fs: make mutating options in Callback readdir() not affect results (LiviaMedeiros) #56057
  • [8d485f1c09] - fs: make mutating options in Promises readdir() not affect results (LiviaMedeiros) #56057
  • [595851b5ed] - fs,win: fix readdir for named pipe (Hüseyin Açacak) #56110
  • [075b36b7b4] - http: add setDefaultHeaders option to http.request (Tim Perry) #56112
  • [febd969c46] - http2: remove duplicate codeblock (Vitaly Aminev) #55915
  • [b0ebd23e52] - http2: support ALPNCallback option (ZYSzys) #56187
  • [f10239fde7] - lib: remove redundant global regexps (Gürgün Dayıoğlu) #56182
  • [fd55d3cbdd] - lib: clean up persisted signals when they are settled (Edigleysson Silva (Edy)) #56001
  • [889094fdbc] - lib: handle Float16Array in node:v8 serdes (Bartek Iwańczuk) #55996
  • [5aec513207] - lib: disable default memory leak warning for AbortSignal (Lenz Weber-Tronic) #55816
  • [b5a2c0777d] - (SEMVER-MINOR) module: add prefix-only modules to module.builtinModules (Jordan Harband) #56185
  • [9863d27566] - (SEMVER-MINOR) module: only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194
  • [5665e86da6] - module: prevent main thread exiting before esm worker ends (Shima Ryuhei) #56183
  • [8e780bc5ae] - (SEMVER-MINOR) module: use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
  • [e5bb6c2303] - (SEMVER-MINOR) module: implement module.registerHooks() (Joyee Cheung) #55698
  • [f883bedceb] - node-api: allow napi_delete_reference in finalizers (Chengzhong Wu) #55620
  • [65bc8e847f] - (SEMVER-MINOR) report: fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068
  • [a6f0cfa468] - sea: only assert snapshot main function for main threads (Joyee Cheung) #56120
  • [0ab36e1937] - (SEMVER-MINOR) sqlite: aggregate constants in a single property (Edigleysson Silva (Edy)) #56213
  • [4745798225] - sqlite: add support for custom functions (Colin Ihrig) #55985
  • [53cc0cc744] - sqlite: support db.loadExtension (Alex Yang) #53900
  • [3968599702] - src: fix outdated js2c.cc references (Chengzhong Wu) #56133
  • [efcc5d90c5] - (SEMVER-MINOR) src,lib: stabilize permission model (Rafael Gonzaga) #56201
  • [a4a83613cb] - stream: commit pull-into descriptors after filling from queue (Mattias Buelens) #56072
  • [3298ef4891] - test: remove test-sqlite-statement-sync flaky designation (Luigi Pinca) #56051
  • [1d8cc6179d] - test: use --permission over --experimental-permission (Rafael Gonzaga) #56239
  • [5d252b7a67] - test: remove exludes for sea tests on PPC (Michael Dawson) #56217
  • [8288f57724] - test: fix test-abortsignal-drop-settled-signals flakiness (Edigleysson Silva (Edy)) #56197
  • [683cc15796] - test: move localizationd data from test-icu-env to external file (Livia Medeiros) #55618
  • [a0c4a5f122] - test: update WPT for url to 6fa3fe8a92 (Node.js GitHub Bot) #56136
  • [a0e3926285] - test: remove hasOpenSSL3x utils (Antoine du Hamel) #56164
  • [041a49094e] - test: update streams wpt (Mattias Buelens) #56072
  • [ea9a675f56] - test_runner: exclude test files from coverage by default (Pietro Marchini) #56060
  • [118cd9998f] - tools: fix node: enforcement for docs (Antoine du Hamel) #56284
  • [c4c56daae8] - tools: update github_reporter to 1.7.2 (Node.js GitHub Bot) #56205
  • [78743b1533] - tools: add REPLACEME check to workflow (Mert Can Altin) #56251
  • [002ee71d9b] - tools: use github.actor instead of bot username for release proposals (Antoine du Hamel) #56232
  • [d25d16efeb] - Revert "tools: disable automated libuv updates" (Luigi Pinca) #56223
  • [b395e0c8c9] - tools: update gyp-next to 0.19.1 (Anna Henningsen) #56111
  • [a5aaf31c50] - tools: fix release proposal linter to support more than 1 folk preparing (Antoine du Hamel) #56203
  • [fa667d609e] - tools: remove has_absl_stringify from gyp file (Michaël Zasso) #56157
  • [65b541e70e] - tools: enable linter for tools/icu/** (Livia Medeiros) #56176
  • [28a4b6ff58] - tools: use commit title as PR title when creating release proposal (Antoine du Hamel) #56165
  • [e20eef659f] - tools: update gyp-next to 0.19.0 (Node.js GitHub Bot) #56158
  • [efcc829085] - tools: bump the eslint group in /tools/eslint with 4 updates (dependabot[bot]) #56099
  • [5620b2be8a] - tools: improve release proposal PR opening (Antoine du Hamel) #56161
  • [3e17a8e78e] - util: harden more built-in classes against prototype pollution (Antoine du Hamel) #56225
  • [13815417c7] - util: fix Latin1 decoding to return string output (Mert Can Altin) #56222
  • [77397c5013] - util: do not rely on mutable Object and Function' constructor prop (Antoine du Hamel) #56188
  • [84f98e0a74] - v8,tools: expose experimental wasm revectorize feature (Yolanda-Chen) #54896
  • [8325fa5c04] - worker: fix crash when a worker joins after exit (Stephen Belanger) #56191

legendecas and others added 30 commits December 10, 2024 20:30
PR-URL: #56131
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #56123
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Fixes: #56044
PR-URL: #56072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
PR-URL: #56072
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
This change sets the default `kMaxEventTargetListeners` property for
`AbortSignal` instances to 0, disabling the check per default, to
enable users to write isomorphic library code.
If desirable, the max event target listeners check can still be
enabled for individual `AbortSignal` instances by calling
`setMaxListeners` on them.

Refs: #54758
PR-URL: #55816
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #56142
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Snapshot main functions are only loaded for main threads in single
executable applications. Update the check to avoid asserting it
in worker threads - this allows worker threads to be spawned in
snapshot main functions bundled into a single executable
application.

PR-URL: #56120
Fixes: #56077
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #55996
Fixes: #55574
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
This reverts commit 542f252.

PR-URL: #56151
Refs: nodejs/build#3963
Refs: #55930
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
PR-URL: #54896
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #56001
Refs: #55328
Fixes: #55328
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
- Open as draft. The releaser should review the PR and mark it as ready.
- Add the "release" label.
- Assign the releaser to the PR so it's clearer who's in charge and
  they can find it more easily. This will also notify and subscribe
  them to the PR.

PR-URL: #56161
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
use_gold is not defined on macOS.

PR-URL: #56141
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Bumps the eslint group in /tools/eslint with 4 updates: [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js), [eslint](https://github.com/eslint/eslint), [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) and [globals](https://github.com/sindresorhus/globals).

Updates `@stylistic/eslint-plugin-js` from 2.10.1 to 2.11.0
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
- [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v2.11.0/packages/eslint-plugin-js)

Updates `eslint` from 9.14.0 to 9.16.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.14.0...v9.16.0)

Updates `eslint-plugin-jsdoc` from 50.4.3 to 50.6.0
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](gajus/eslint-plugin-jsdoc@v50.4.3...v50.6.0)

Updates `globals` from 15.11.0 to 15.12.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v15.11.0...v15.12.0)

---
updated-dependencies:
- dependency-name: "@stylistic/eslint-plugin-js"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: globals
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56099
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56158
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
In favor of `hasOpenSSL`.

PR-URL: #56164
Refs: https://github.com/nodejs/node/pull/56160/files#r1874118863
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #56165
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #56172
Refs: #56173
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: theanarkh <[email protected]>
PR-URL: #56176
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #55698
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #55698
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
PR-URL: #56136
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #56178
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
File was removed in #54536

PR-URL: #56157
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56182
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56110
Fixes: #56002
Refs: #55623
Refs: #56088
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
The link to the style guide in `pull-requests.md` linked to the main
`README.md` instead of `doc/README.md`. This commit fixes the link.

Refs: #41119
PR-URL: #56181
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Add an initial message to be promoted.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #56085
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55618
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
selveter and others added 26 commits December 18, 2024 22:31
PR-URL: #56216
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #56239
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56222
Fixes: #56219
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #55432
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55562
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #55780
Fixes: #55340
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools

PR-URL: #56238
Refs: #55784
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56225
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
This action reminds collaborators of the upcoming
major release date. In the future, this action can
also update and create the branches (that's why the
action name is generic).

PR-URL: #56199
Refs: #55732
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #56256
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #56251
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #56060
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>
Fixes: #56137
Refs: #56223
PR-URL: #56224
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #56255
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56258
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #56284
Refs: #56185
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #56213
Fixes: #56193
Refs: #56193
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #56265
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
PR-URL: #56266
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Signed-off-by: 吴小白 <[email protected]>
PR-URL: #56271
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Attributes are being highlighted as #f00 on a background of #f2f2f2.
That's a color contrast of 3.98:1, failing to meet the 4.5:1 requirement
of WCAG 2.1 AA. This changes the attribute color to #d00, which has a
color contrast of 5.09:1 meeting the 4.5:1 requirement.

PR-URL: #56272
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Notable changes:

crypto:
  * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142
dgram:
  * (SEMVER-MINOR) support blocklist in udp (theanarkh) #56087
doc:
  * stabilize util.styleText (Rafael Gonzaga) #56265
module:
  * (SEMVER-MINOR) add prefix-only modules to `module.builtinModules` (Jordan Harband) #56185
  * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194
  * (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
  * (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
report:
  * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068
sqlite:
  * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) #56213
src,lib:
  * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) #56201

PR-URL: #56310
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 94.83003% with 73 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (e8cf3a6) to head (d8c3089).
Report is 1 commits behind head on v23.x.

Files with missing lines Patch % Lines
src/node_sqlite.cc 82.62% 18 Missing and 27 partials ⚠️
lib/dgram.js 83.33% 6 Missing ⚠️
lib/internal/modules/cjs/loader.js 97.46% 6 Missing ⚠️
lib/internal/test_runner/utils.js 0.00% 5 Missing ⚠️
lib/internal/modules/esm/loader.js 94.44% 3 Missing ⚠️
lib/assert.js 98.90% 2 Missing ⚠️
lib/internal/modules/esm/translators.js 94.11% 2 Missing ⚠️
lib/internal/process/pre_execution.js 66.66% 1 Missing ⚠️
lib/internal/util/inspect.js 97.56% 1 Missing ⚠️
src/js_native_api_v8.cc 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v23.x   #56310      +/-   ##
==========================================
+ Coverage   88.27%   88.55%   +0.28%     
==========================================
  Files         656      657       +1     
  Lines      189083   190225    +1142     
  Branches    36235    36545     +310     
==========================================
+ Hits       166906   168458    +1552     
+ Misses      15366    14954     -412     
- Partials     6811     6813       +2     
Files with missing lines Coverage Δ
lib/_http_client.js 97.99% <100.00%> (+0.01%) ⬆️
lib/buffer.js 100.00% <100.00%> (+1.31%) ⬆️
lib/fs.js 98.19% <100.00%> (+5.00%) ⬆️
lib/internal/abort_controller.js 98.14% <100.00%> (+0.08%) ⬆️
lib/internal/bootstrap/realm.js 96.03% <100.00%> (-3.97%) ⬇️
lib/internal/crypto/util.js 93.05% <100.00%> (-0.05%) ⬇️
lib/internal/fs/glob.js 92.63% <100.00%> (+1.93%) ⬆️
lib/internal/fs/promises.js 98.24% <100.00%> (+0.69%) ⬆️
lib/internal/http2/core.js 95.53% <100.00%> (+0.03%) ⬆️
lib/internal/modules/customization_hooks.js 100.00% <100.00%> (ø)
... and 34 more

... and 78 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.