Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Modal Accessibility in WithSearchBox with RemoveScroll and FocusLock #6976

Closed
wants to merge 1 commit into from

Conversation

47anjan
Copy link

@47anjan 47anjan commented Aug 2, 2024

This pull request addresses issues with users accidentally scrolling outside the modal or tabbing to elements behind the modal in the WithSearchBox component. It implements the use of RemoveScroll and FocusLock within the modal to enhance accessibility and improve user experience.

Changes Made:

  • Added RemoveScroll to prevent scrolling outside of the modal.
  • Added FocusLock to maintain keyboard focus within the modal.

Validation

To validate these changes, reviewers should:

  1. Open the WithSearchBox modal.
  2. Verify that scrolling outside the modal is disabled.
  3. Navigate the modal using the keyboard and ensure that focus remains within the modal content.
  4. Check that the modal interaction is smooth and no elements outside the modal can be accessed accidentally.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@47anjan 47anjan requested a review from a team as a code owner August 2, 2024 05:39
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Aug 2, 2024 5:39am

@canerakdas

This comment was marked as duplicate.

@bmuenzenmeyer
Copy link
Collaborator

agree with Caner on this - #6908 will supercede any work here, or recontextualize it so much as to make the drift too much.
given this is stale now for two months, i am closing.

@47anjan thanks for your care in contributing here. i think we should ensure that #6975 is resolved with #6908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Issues with Scrolling and Focus in WithSearchBox Modal
3 participants