Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sops #147

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs: add sops #147

wants to merge 2 commits into from

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Oct 25, 2024

Closes #139

Closes #139

Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Copy link

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really good WIP! nicely done

in addition to my comments, I wanted to show you https://sembr.org/ - I try to use it in all my markdown writing as it makes for much much cleaner diffs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - this content assumes someone will be viewing it in a filesystem with the sibling files present. a slight improvement would be to list the content as urls here as a sort of table of contents.

certainly not a blocker.

the small size of the other files could even suggest that ALL the content is housed in the README direct

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these flows supposed to have mermaid diagrams or something?


## Steps

- Check [Sentry](https://nodejs-org.sentry.io/issues/?project=4506191181774848). All errors should be reported here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an assumption that people will have this access?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i liked the detail on this file


## What is it?

[R2](https://developers.cloudflare.com/r2/) is Cloudflare's blog storage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[R2](https://developers.cloudflare.com/r2/) is Cloudflare's blog storage
[R2](https://developers.cloudflare.com/r2/) is Cloudflare's blob storage


When a release is ready to be released, it is promoted. For mainline releases,
this is done by the releaser running the [`release.sh`](https://github.com/nodejs/node/tree/main/tools/release.sh)
script in the Node.js repository. For nightly releases, this is done once a day.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you link to the nightly action?


- Optional, but preferably updates will be echoed on social media.

- Please also monitor any issues in repositories such as

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for prolonged outages, consider pinning one issue so as to avoid spam

@@ -0,0 +1,26 @@
# Switching Between The Worker and The Origin Server

Steps for toggling serves production traffic between the Release Worker and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be server?

Suggested change
Steps for toggling serves production traffic between the Release Worker and
Steps for toggling server production traffic between the Release Worker and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as someone less familiar with all this, can you explain why someone would want to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding SOPs
2 participants