Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Variables into a .config file #20

Open
fforres opened this issue Jan 20, 2016 · 5 comments
Open

GH Variables into a .config file #20

fforres opened this issue Jan 20, 2016 · 5 comments

Comments

@fforres
Copy link
Member

fforres commented Jan 20, 2016

What if we add a fallback for the Github variables gh-token, gh-client-id, gh-client-secret into a .config file that you could fill?

i.e. @ groupon we have those env. variables already set into our computers, but for Groupon's Enterprise Github.

@martinheidegger
Copy link
Contributor

PR welcome 😄 👍

@fforres
Copy link
Member Author

fforres commented Jan 20, 2016

Will do :)

@fforres
Copy link
Member Author

fforres commented Jan 23, 2016

Adding a PR: #30

@dinodsaurus
Copy link
Member

I think we can close this one because we wont need github variables. What do you think @martinheidegger

@martinheidegger
Copy link
Contributor

For the moment this PR has become obsolete but we might need it in future versions if we add advanced features to the tool

@dinodsaurus dinodsaurus reopened this Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants