Merge pull request #218 from noi-techpark/footer

Footer update
noi-techpark · Jun 10, 2024 · 016e0a7 · 016e0a7
2 parents c688505 + 119a54b
commit 016e0a7
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 29 deletions.
diff --git a/frontend/src/assets/styles/styles.scss b/frontend/src/assets/styles/styles.scss
@@ -308,7 +308,7 @@ main {
     text-decoration: underline;
 }
 
-.text-underline:hover {
+.text-underline-hover:hover {
     text-decoration: underline !important;
 }
 

diff --git a/frontend/src/layouts/partials/footer.vue b/frontend/src/layouts/partials/footer.vue
@@ -60,23 +60,34 @@ SPDX-License-Identifier: AGPL-3.0-or-later
           <div class="col-12 col-lg-3">
             <div class="d-flex flex-column">
               <span class="mb-1 text-semibold">Relevant links</span>
-              <a href="/">Web Components</a>
-              <a href="/how-to-add/">How To Add</a>
-              <a href="/how-to-create/">How To Create</a>
-              <a href="/validator/">Validator</a>
-              <a href="https://opendatahub.com/contact" target="_blank"
+              <a class="text-underline-hover" href="/">Web Components</a>
+              <a class="text-underline-hover" href="/how-to-add/">How To Add</a>
+              <a class="text-underline-hover" href="/how-to-create/"
+                >How To Create</a
+              >
+              <a class="text-underline-hover" href="/validator/">Validator</a>
+              <a
+                class="text-underline-hover"
+                href="https://opendatahub.com/contact"
+                target="_blank"
                 >Contact</a
               >
             </div>
           </div>
           <div class="col-12 col-lg-3 mt-3 mt-lg-0">
             <div class="d-flex flex-column">
               <span class="mb-1 text-semibold">Quickstart</span>
-              <a href="https://opendatahub.com" target="_blank"
+              <a
+                class="text-underline-hover"
+                href="https://opendatahub.com"
+                target="_blank"
                 >Open Data Hub Website</a
               >
-              <a class="text-decoration-underline" href="/">Web Components</a>
-              <a href="https://databrowser.opendatahub.com" target="_blank"
+              <a class="text-underline-hover" href="/">Web Components</a>
+              <a
+                class="text-underline-hover"
+                href="https://databrowser.opendatahub.com"
+                target="_blank"
                 >Databrowser</a
               >
             </div>
@@ -88,7 +99,7 @@ SPDX-License-Identifier: AGPL-3.0-or-later
                 >The Web Component Store is the result of a great collaboration
                 between many awesome people!
                 <a
-                  class="text-decoration-underline"
+                  class="text-underline-hover"
                   href="https://opendatahub.com/community#contributors"
                   target="_blank"
                 >
@@ -212,4 +223,8 @@ export default {
 .border-black {
   border-color: black !important;
 }
+
+.underline-hover:hover {
+  text-decoration: underline;
+}
 </style>
diff --git a/frontend/src/layouts/partials/nav.vue b/frontend/src/layouts/partials/nav.vue
@@ -39,20 +39,20 @@ SPDX-License-Identifier: AGPL-3.0-or-later
             <b-navbar-nav class="flex-grow-1 align-items-center">
               <b-nav-item-dropdown text="How to">
                 <b-dropdown-item
-                  :to="localePath('how-to-add/')"
+                  :to="localePath('/how-to-add/')"
                   @click="$emit('hide-overlay')"
                 >
                   Add a webcomponent
                 </b-dropdown-item>
                 <b-dropdown-item
-                  :to="localePath('how-to-create/')"
+                  :to="localePath('/how-to-create/')"
                   @click="$emit('hide-overlay')"
                 >
                   Create a webcomponent
                 </b-dropdown-item>
               </b-nav-item-dropdown>
               <b-nav-item
-                :to="localePath('validator/')"
+                :to="localePath('/validator/')"
                 @click="$emit('hide-overlay')"
               >
                 Validator
@@ -63,17 +63,6 @@ SPDX-License-Identifier: AGPL-3.0-or-later
               >
                 Contact
               </b-nav-item>
-              <a
-                class="ml-auto no-external-icon text-small d-none d-lg-inline"
-                href="https://opendatahub.com"
-                target="_blank"
-              >
-                <img
-                  class="pl-2 logo-open-data-hub"
-                  src="/open-data-hub-sm.svg"
-                  alt="Open Data Hub"
-                />
-              </a>
             </b-navbar-nav>
           </b-collapse>
         </b-navbar>
@@ -112,11 +101,6 @@ export default {
   width: 2.2rem;
 }
 
-.nav-item:not(.no-external-icon) [target='_blank']::after {
-  padding-left: 0.4rem;
-  content: url(/icons/external.svg);
-}
-
 .nav-item .nuxt-link-exact-active {
   font-weight: bold;
 }