chore: Do not print entire functions when running debug trace #6814
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
commented
Dec 13, 2024
compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
Outdated
Show resolved
Hide resolved
Peak Memory Sample
|
Compilation Sample
|
…ncs' into mv/smaller-trace-do-not-print-funcs
TomAFrench
approved these changes
Dec 13, 2024
vezenovm
commented
Dec 13, 2024
compiler/noirc_evaluator/src/ssa/checks/check_for_underconstrained_values.rs
Show resolved
Hide resolved
vezenovm
commented
Dec 13, 2024
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 14, 2024
…race (noir-lang/noir#6814) chore(ci): Active rollup circuits in compilation report (noir-lang/noir#6813) feat(ssa): Bring back tracking of RC instructions during DIE (noir-lang/noir#6783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
I was running
NOIR_LOG=trace nargoon some programs and my entire output was entirely filled with the SSA of my program. I was unsure where we were printing this SSA, but then I found that a couple trace macros are called in the under constrained values check where we state which function we are processing. We should print the ID, not the entire function.Summary*
I switched to using func IDs instead of the entire function. This makes the trace actually readable. I could turn off the underconstrained check, but I think we should switch this to use an ID either way. Someone attempting to use
traceshould not have to know that they need this flag in order to get some reasonable debug output.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.