-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simmetry class improvement #103
Comments
@hampusnasstrom FYI |
There is a paper: https://www.sciencedirect.com/science/article/pii/S0927025614003322?via%3Dihub#s0050 But the question is whether we need to do any API request if someone (maybe @lauri-codes) already did this and hard-coded it in |
Oki, I'm open to evaluate the best option |
@aalbino2 Thank you for bringing this up. My main question is what data you would want to retrieve? Typically, we use API calls during the normalization to obtain identifiers that are interoperable with other systems. As @JosePizarro3 pointed out, API calls are a frequent bottleneck and point of failure, but this application is still manageable.
This is a larger data migration project that should be overseen by Markus. These migrations did happen in the past to grow out the NOMAD database. In that sense, they remain useful, and I actually requested such a migration for R2SCAN data a few times now. However, these migrations also have a political dimension. The original host databases also apply for funding and rightfully don't want to divert traffic away from their site. I'd therefore say that it's best to coordinate these endeavors with Pepe. Finally, there is already a consortium tackling a common API language where NOMAD and AFLOW both participate in, namely OPTIMADE. From an end user's perspective, the only added values of a data migration to NOMAD are:
|
What I had in mind was something similar to what happens in PubChemPureSubstance, e.g., the user is filling one quantity within an instance of that class and on save the api query is filling the other quantities. In this case the (experimental) user would log their own Sample and indicate the space group. On save, all the quyntities in Simmetry class would be automatically filled with info such as Bravais lattice, or whatever else that right now I'm now aware of. I also see the Simmetry class as and important connection of data structure between A and C and apart from the API query I would in the future start to use it |
To start, I suggest going with a function which uses the aflow_prototype dictionary in nomad, and given some quantity (e.g., the Then, we wait for the decision on the API. This method I am talking about do not depend on the specific reading of the information. |
This should not be done through an API. The information is so stable and small that it should be available offline. E.g. |
We also do have an offline version of AFLOW protototype library, but this is actually very different from spacegroup number as it also contains the occupation of Wyckoff positions and is associated with a very specific example structure. |
Ok, thanks @lauri-codes @aalbino2 ! I was checking a couple of other things regarding magnetic group symmetries over the weekend, so I see we have a couple of tasks to improve For now, I will implement a method to resolve Symmetry quantities based on a given input and using spglib / aflow_prototypes from nomad.atomutils. Later for magnetic symmetries, I want to get some feedback from other people as well. I will separate this in a different issue. In any case, both implementations will take a while. |
Okay, sounds good @JosePizarro3. Just pin me when you need some feedback, I can test it and check if everything needed from my side is included. |
Hi, I was looking at Simmetry class and I believe that this is very useful also in synthesis experiments.
Checking the code with @JosePizarro3 we saw some aflow database info, they are currently not fetched through an API call but hardcoded in nomad.
How about implementing a way of fetching all the info directly from their database? Something similar to what is implement for a PureSubstance querying the PubChem database.
I could take a look into that if you think that it might be interesting @JFRudzinski @ndaelman-hu @Bernadette-Mohr
The text was updated successfully, but these errors were encountered: