From 3f8e7a4705771b0485caa50897f340ab42e5532c Mon Sep 17 00:00:00 2001 From: Jaya Allamsetty Date: Thu, 20 Jun 2024 11:13:31 -0400 Subject: [PATCH] fix(CodecSelectionTest) Configure codec preference explicitly. Do not assume defaults since different deployments have different settings. --- .../java/org/jitsi/meet/test/CodecSelectionTest.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/jitsi/meet/test/CodecSelectionTest.java b/src/test/java/org/jitsi/meet/test/CodecSelectionTest.java index 0cdab8df9..fd8a22f89 100644 --- a/src/test/java/org/jitsi/meet/test/CodecSelectionTest.java +++ b/src/test/java/org/jitsi/meet/test/CodecSelectionTest.java @@ -50,7 +50,8 @@ public void setupClass() @Test public void testAsymmetricCodecs() { - ensureOneParticipant(getJitsiMeetUrl()); + ensureOneParticipant(getJitsiMeetUrl() + .appendConfig("config.videoQuality.codecPreferenceOrder=[ 'VP9', 'VP8', 'AV1' ]")); WebParticipant participant1 = getParticipant1(); WebParticipant participant2 = joinSecondParticipant(getJitsiMeetUrl() @@ -153,7 +154,10 @@ public void testCodecSwitchOver() { hangUpAllParticipants(); - ensureTwoParticipants(); + JitsiMeetUrl url = getJitsiMeetUrl() + .appendConfig("config.videoQuality.codecPreferenceOrder=[ 'VP9', 'VP8', 'AV1' ]"); + + ensureTwoParticipants(url, url); WebParticipant participant1 = getParticipant1(); WebParticipant participant2 = getParticipant2(); @@ -171,10 +175,10 @@ public void testCodecSwitchOver() "return JitsiMeetJS.app.testing.isLocalCameraEncodingVp9();", 10); - JitsiMeetUrl url = getJitsiMeetUrl() + JitsiMeetUrl meetUrl = getJitsiMeetUrl() .appendConfig("config.videoQuality.codecPreferenceOrder=[ 'VP8' ]"); - WebParticipant participant3 = joinThirdParticipant(url, null); + WebParticipant participant3 = joinThirdParticipant(meetUrl, null); participant3.waitToJoinMUC(); participant3.waitForIceConnected(); participant3.waitForSendReceiveData(true, true);