-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long printer name can overflow in printer list #16
Comments
Thanks for the report! Looks like a missing UI constraint in https://github.com/nordprojects/littleprinters-ios-app/blob/master/littleprinter/UI/Printers/PrinterListTableViewCell.swift#L135 Happy to review a PR if you're interested! |
@joerick Thanks for the tip! I'm not super familiar with Swift, but purely based on what the rest looks like, I suppose If this is an acceptable solution for you, I'll be happy to create a PR! |
Sounds good to me! |
Steps to reproduce
Expected result
The printer name is truncated with an ellipsis, or wraps to a new line.
Actual result
The printer name stacks with the key icon, and overflows outside of the box:
This is a purely cosmetic issue, the usability of the key icon is not affected.
Configuration: iPod touch 7th generation, iOS 13.7, Little Printers 1.0.1.
The text was updated successfully, but these errors were encountered: