Add line-number and tab-line #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a README with my modifications
|
Should the commit that creates the readme be part of this pull request? I would assume not. |
|
Fine with me /PA
Enviado desde mi iPhone
… El 2 ene 2021, a las 19:44, ssnnoo ***@***.***> escribió:
Should the commit that creates the readme be part of this pull request? I would assume not.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Hi @paaguti 👋, thanks for your contribution 👍 I've added this PR to the backlog for a detailed review. Please note that it might take some time due to the high amount of work in the Nord project and the currently limited free time to process all the task queues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for some "modern" emacs faces:
line-number is present in emacs-26 and tab-line in emacs-27.
I basically inherit from fringe to create a uniform view in all things around the editing buffer.
This is my current setup on an emacs27 on Ubuntu20.04 with nord-theme and doom-modeline:
Explanation: Upper frame is my nord-theme.el with line numbers as per emacs26 and later. Lower frame is the README.md
no line numbers there, because I disable them for non-progmode buffers.
Regarding tab line, I distinguish between buffer that is currently being edited, buffers shown in other windows and inactive buffers.