Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS parentheses in string templates use string color #162

Closed
kufii opened this issue Oct 8, 2019 · 6 comments · Fixed by #163
Closed

JS parentheses in string templates use string color #162

kufii opened this issue Oct 8, 2019 · 6 comments · Fixed by #163

Comments

@kufii
Copy link
Contributor

kufii commented Oct 8, 2019

photo_2019-10-08_13-19-35

See the parens on line 6?

I did the following workaround in my settings.json to fix it

{
  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": [
          "meta.embedded.line.js meta.brace.square.js",
          "meta.embedded.line.js meta.brace.round.js"
        ],
        "settings": {
          "foreground": "#eceff4"
        }
      }
    ]
  }
}
@arcticicestudio
Copy link
Contributor

Hi @kufii 👋, thanks for your contribution 👍
I'll reproduce the problem and merge your changes when it works fine. Or if you'd like to submit a PR feel free to do so, maybe you're attending at Hacktoberfest.

@kufii
Copy link
Contributor Author

kufii commented Oct 9, 2019

PR submitted!

@IgorKrupenja
Copy link

Off-topic: I was wondering which font are you using in that screenshot?

@kufii
Copy link
Contributor Author

kufii commented Oct 26, 2019

It's operator mono with ligatures

@IgorKrupenja
Copy link

Thanks!

@svipas
Copy link

svipas commented Oct 29, 2019

This is already fixed in this PR with more fixes for JS & TS.

@arcticicestudio arcticicestudio added this to the Next milestone Jun 22, 2020
@arcticicestudio arcticicestudio removed their assignment Jun 22, 2020
arcticicestudio pushed a commit that referenced this issue Jun 23, 2020
Improved the highlighting of braces within JavaScript template literals [1] to use `nord4` as foreground color instead of `nord14` like strings.

[1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Co-authored-by: Arctic Ice Studio <[email protected]>
Co-authored-by: Sven Greb <[email protected]>

Resolves GH-162
arcticicestudio pushed a commit that referenced this issue Feb 1, 2021
Improved the highlighting of braces within JavaScript template literals [1] to use `nord4` as foreground color instead of `nord14` like strings.

[1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Co-authored-by: Arctic Ice Studio <[email protected]>
Co-authored-by: Sven Greb <[email protected]>

Resolves GH-162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants