Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal colors #245

Open
Jessidhia opened this issue Mar 10, 2022 · 2 comments
Open

Terminal colors #245

Jessidhia opened this issue Mar 10, 2022 · 2 comments

Comments

@Jessidhia
Copy link

Jessidhia commented Mar 10, 2022

Description

The VSCode extension currently does not update the terminal colors, which is part of the workbench theming.

Benefits

Built-in terminal no longer shows unthemed default colors.

Alternative Solutions

I found a copy&paste-able theme in https://glitchbone.github.io/vscode-base16-term/#/nord but it just haphazardly assigns nord palette colors, so you get things like "green" being shown with a red color.

Example

I have ported the colors from nord's official alacritty config to vscode's config format:

{
  "workbench.colorCustomizations": {
    "terminal.background": "#2e3440",
    "terminal.foreground": "#d8dee9",
    "terminalCursor.background": "#2e3440",
    "terminalCursor.foreground": "#d8dee9",
    "terminal.selectionBackground": "#4c566a",
    "terminal.ansiBlack": "#3b4252",
    "terminal.ansiRed": "#bf616a",
    "terminal.ansiGreen": "#a3be8c",
    "terminal.ansiYellow": "#ebcb8b",
    "terminal.ansiBlue": "#81a1c1",
    "terminal.ansiMagenta": "#b48ead",
    "terminal.ansiCyan": "#88c0d0",
    "terminal.ansiWhite": "#e5e9f0",
    "terminal.ansiBrightBlack": "#4c566a",
    "terminal.ansiBrightRed": "#bf616a",
    "terminal.ansiBrightGreen": "#a3be8c",
    "terminal.ansiBrightYellow": "#ebcb8b",
    "terminal.ansiBrightBlue": "#81a1c1",
    "terminal.ansiBrightMagenta": "#b48ead",
    "terminal.ansiBrightCyan": "#8fbcbb",
    "terminal.ansiBrightWhite": "#eceff4"
  }
}

(the cursor background/foreground look swapped here but "without swapping" the block cursor was invisible)

@bronze
Copy link

bronze commented Jun 11, 2022

my terminal got funky too. what was supposed to be white is now black on vscode's terminal. same text on windows terminal remains white. using powerlevel10k on zsh

@svengreb
Copy link
Member

Thank you for your patience! 🙏🏼
It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the queue in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@Jessidhia Thanks again for your contribution 🚀
The issue has been added to the queue and the review will be planned for the next iterations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: queued
Development

No branches or pull requests

3 participants