You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The wildcard checks in DefaultPermissionsProvider are essentially inverted.
Because of this line, the permissions superset will contain the sub-permissions as a wildcard. This is not optimal as plugins aren't checking for group.*, rather group.permission
Configured wildcards should support any level of nesting; possible iterations should be processed in the HasPermission method.
The change would make the SpecialPermissionsSuperset redundant. This set could be reused to cache all permissions including inherited groups, reducing the complexity and improving the efficiency of the HasPermission method (as there wouldn't be dictionary lookups nor recursion).
The text was updated successfully, but these errors were encountered:
The wildcard checks in
DefaultPermissionsProvider
are essentially inverted.Because of this line, the permissions superset will contain the sub-permissions as a wildcard. This is not optimal as plugins aren't checking for
group.*
, rathergroup.permission
Configured wildcards should support any level of nesting; possible iterations should be processed in the
HasPermission
method.The change would make the
SpecialPermissionsSuperset
redundant. This set could be reused to cache all permissions including inherited groups, reducing the complexity and improving the efficiency of theHasPermission
method (as there wouldn't be dictionary lookups nor recursion).The text was updated successfully, but these errors were encountered: