Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping not working on Ping Redirect (Type 5) #84

Open
Kr0san89 opened this issue Aug 25, 2022 · 0 comments
Open

Ping not working on Ping Redirect (Type 5) #84

Kr0san89 opened this issue Aug 25, 2022 · 0 comments

Comments

@Kr0san89
Copy link

Kr0san89 commented Aug 25, 2022

Hello,

i found in networks where the GW sends an ICMP Typ5 Message (Redirect) (https://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml#icmp-parameters-codes-5) this module just returns an error.

Ping error RedirectReceivedError: Redirect received (source=<gw ip>)

I did the same ping with the linux ping tool and this returns
ping -v <ip> PING <ip> (<ip>) 56(84) Bytes Data. From<gw ip> icmp_seq=1 Host redirect(New nexthop: < other router ip>) 64 Bytes from <ip>: icmp_seq=1 ttl=63 Zeit=26.3 ms 64 Bytes from <ip>: icmp_seq=2 ttl=63 Zeit=9.43 ms

Not completly sure how to fix this i assume on type 5 the node-net-ping package shouldn't error but rather keep going?
L 306
else if (req.type == 5) { req.callback (new RedirectReceivedError (source), req.target, req.sent, new Date ()); }
The error is quite anoying as all the ips are not "pingable"

I would contribute a change, if someone knows getting rid of the error is sufficient (not so in the details of ping)

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant