-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running of unmodified envs with original done
signals
#27
Comments
Hey Gary, as in Deep RL from Human Preferences, we remove the You can see the I'd be interested in accepting PRs that make it easy to run the unmodified environments as well as the modified ones. See the following issue: |
done
signals
done
signals done
signals
Thanks for clarifying |
I'm leaving this open because it's a separate issue from #5 |
Ah, actually this is already an open issue. Closing in favor of #12 |
I try this and watch the movies
python -u rl_teacher/teach.py -p rl -e Humanoid-v1 -n base-rl -w 12
It always runs the full 1000 steps. Putting in a print statement in rollouts.py shows that the env.step never returns a 'done'
Is it supposed to be like this? If so, why?
The text was updated successfully, but these errors were encountered: