Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running of unmodified envs with original done signals #27

Closed
garymcintire opened this issue Aug 4, 2017 · 4 comments
Closed

Allow running of unmodified envs with original done signals #27

garymcintire opened this issue Aug 4, 2017 · 4 comments

Comments

@garymcintire
Copy link

I try this and watch the movies

python -u rl_teacher/teach.py -p rl -e Humanoid-v1 -n base-rl -w 12

It always runs the full 1000 steps. Putting in a print statement in rollouts.py shows that the env.step never returns a 'done'

Is it supposed to be like this? If so, why?

@nottombrown
Copy link
Owner

Hey Gary, as in Deep RL from Human Preferences, we remove the done signals.

You can see the envs.py file for details.

I'd be interested in accepting PRs that make it easy to run the unmodified environments as well as the modified ones.

See the following issue:
#5

@nottombrown nottombrown changed the title Humanoid does not seem to see done Allow running of unmodified Mujoco environments with original done signals Aug 5, 2017
@nottombrown nottombrown changed the title Allow running of unmodified Mujoco environments with original done signals Allow running of unmodified envs with original done signals Aug 5, 2017
@garymcintire
Copy link
Author

Thanks for clarifying

@nottombrown
Copy link
Owner

I'm leaving this open because it's a separate issue from #5

@nottombrown
Copy link
Owner

Ah, actually this is already an open issue. Closing in favor of #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants