Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icmp union strange result #65

Closed
haim-kermany opened this issue Sep 25, 2024 · 5 comments · Fixed by #67
Closed

icmp union strange result #65

haim-kermany opened this issue Sep 25, 2024 · 5 comments · Fixed by #67
Assignees
@haim-kermany
Labels
bug Something isn't working

Comments

@haim-kermany
Copy link
Contributor

haim-kermany commented Sep 25, 2024 •
edited by adisos
Loading

(came from icmpv6 rule)

obj1: ICMP icmp-type: 135-136
obj2: ICMP
ob1 union obj2: ICMP icmp-type: 0-16,135-136
@haim-kermany haim-kermany self-assigned this Sep 25, 2024
@haim-kermany
Copy link
Contributor Author

haim-kermany commented Sep 26, 2024 •
edited
Loading

the issue is that the max value of icmp-type is defined at the model to be 16, the max value of icmp-code is 5.
these max values are based on https://datatracker.ietf.org/doc/html/rfc792.

on the other hand, these parameters has 8bits, and and defined to be 0-255 here:
https://vdc-download.vmware.com/vmwb-repository/dcr-public/ce4128ae-8334-4f91-871b-ecce254cf69e/488f1280-204c-441d-8520-8279ac33d54b/api_includes/types_ICMPTypeServiceEntry.html

in practice, at the services I get from the nsx api, the values of icmp-code is 0, (or missing), the values of icmp-type is 0-143

@haim-kermany
Copy link
Contributor Author

@adisos @zivnevo @kyorav

@adisos
Copy link
Contributor

adisos commented Sep 27, 2024

Thanks @haim-kermany . Can you push the branch with the test that demonstrates this issue?

@adisos adisos added the bug Something isn't working label Sep 27, 2024
@adisos adisos changed the title union strange result icmp union strange result Sep 27, 2024
@haim-kermany
Copy link
Contributor Author

created a pr with the test only.

@adisos adisos linked a pull request Sep 29, 2024 that will close this issue
fix icmp type and code ranges #67
Merged
@adisos adisos mentioned this issue Sep 29, 2024
Merged
@adisos
Copy link
Contributor

adisos commented Sep 29, 2024

Pushed to this branch a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haim-kermany haim-kermany

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix icmp type and code ranges np-guard/models
2 participants
@haim-kermany @adisos