Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Network Policy: eval command support #423

Merged
merged 130 commits into from
Dec 1, 2024
Merged

Admin Network Policy: eval command support #423

merged 130 commits into from
Dec 1, 2024

Conversation

shireenf-ibm
Copy link
Contributor

@shireenf-ibm shireenf-ibm commented Oct 20, 2024 •
edited
Loading

#380 adding support to eval command
issue #443

  1. updated funcs related to eval command under eval pkg (for my convenience, i have separated the funcs of check.go file into 2 files, the new file is check_eval.go; all the related funcs to eval command (checking if specific conn is allowed) are there
  2. successfully running unit-tests from parsed resources in eval_test.go
  1. added new command-line tests :eval command with tests with ANPs (added relevant support for new policies (anps+banp) + for pods that are actually replica of a workload object that is not defined as Pod in the yamls (e.g. StatefulSet))

@shireenf-ibm
adding ANP to parser.k8sobj
7286094
@shireenf-ibm
fixing gocritic rangeValCopy by indexing
cc14430
@shireenf-ibm
Merge github.com:np-guard/netpol-analyzer into support_admin_netpolicy
bb14609
@shireenf-ibm
Merge branch 'main' of github.com:np-guard/netpol-analyzer into suppo…
03af344 
…rt_admin_netpolicy
@shireenf-ibm
Merge github.com:np-guard/netpol-analyzer into support_admin_netpolicy
47b8718
@shireenf-ibm
w.i.p. anp support - first commit
150f698
@shireenf-ibm
more examples (2 ANPs/ ANP+NP)
87243c2
@shireenf-ibm
fixing references
4adf709
@shireenf-ibm
new_test that ensures rule ordering in ANP is respected
d25107d
@shireenf-ibm
update the conn representation as complement in case it is shorter (a…
d72b159 
…ll but: udp 5353 instead of SCTP 1-65535,TCP 1-65535,UDP 1-5352,5354-65535)
@shireenf-ibm
test with swapped rules from another test + diff test
4dfeb6d
@shireenf-ibm
more-tests
de0ff91
@shireenf-ibm
fixing conns computations and a test with multiple ANPs
3eacc3c
@shireenf-ibm
extending output formats of existing tests
0a85d43
@shireenf-ibm
tiny fix
3e9db6e
@shireenf-ibm
fixing a tinu bug in ruleConnections func
836ed4f
@shireenf-ibm
tiny doc updte
6641bfd
@shireenf-ibm
tiny doc update
619cb88
@shireenf-ibm
a @todo tbd while review
b082158
@shireenf-ibm
return error if ANPs are without name or not unique names
484d447
@shireenf-ibm
remove redundant lines
71031e8
@shireenf-ibm
reverting the changes adding complement string representation (all bu…
f672a0b 
…t) for connectionSet
@shireenf-ibm
Merge github.com:np-guard/netpol-analyzer into support_admin_netpolicy
eb7a685
@shireenf-ibm
Merge remote-tracking branch 'origin/HEAD' into support_admin_netpolicy
634706f
@shireenf-ibm
minor updates to netpol_errors
2e2ca27
@shireenf-ibm
currently disabling exposure-analysis when there are admin-network-po…
bc29f3f 
…licies in the input resources
@shireenf-ibm
some organizations (mainly comments updates)
56e9f5d
@shireenf-ibm
updating some todo messages
6391bbe
@shireenf-ibm
updating some todo messages/questions
9b93505
@shireenf-ibm
todo question
fb5a582
@shireenf-ibm shireenf-ibm linked an issue Nov 12, 2024 that may be closed by this pull request
eval command : support (Baseline)AdminNetworkPolicy #443
Closed
@shireenf-ibm shireenf-ibm requested a review from adisos November 13, 2024 14:13
Base automatically changed from support_admin_netpolicy to main November 28, 2024 11:42
@shireenf-ibm shireenf-ibm changed the title eval command support Admin Network Policy: eval command support Nov 28, 2024
@shireenf-ibm shireenf-ibm marked this pull request as ready for review November 28, 2024 13:32
adisos
adisos reviewed Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix a conflict in go.mod

@shireenf-ibm shireenf-ibm requested a review from adisos December 1, 2024 07:54
@shireenf-ibm shireenf-ibm merged commit 16eb79f into main Dec 1, 2024
4 checks passed
@shireenf-ibm shireenf-ibm deleted the support_anp_for_eval_cmd branch December 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

@tanyaveksler tanyaveksler Awaiting requested review from tanyaveksler

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eval command : support (Baseline)AdminNetworkPolicy
3 participants
@shireenf-ibm @adisos @tanyaveksler