Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named_ports warnings are no longer counted in config findings #91

Open
zivnevo opened this issue Aug 1, 2024 · 0 comments
Open

Named_ports warnings are no longer counted in config findings #91

zivnevo opened this issue Aug 1, 2024 · 0 comments
Labels
testing

Comments

@zivnevo
Copy link
Member

zivnevo commented Aug 1, 2024

Named_ports are now resolved in ConnectivityProperties::make_conn_props during building policies. ConnectivityProperties do not have access to the policy object. Therefore, all warnings related to named_ports resolution are printed but not counted in policy findings.
Currently, changed the expected warnings number in relevant scheme files, to make the tests pass.
Consider the possibility of adding the mechanism of warning counting to ConnectivityProperties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zivnevo