From f76f74610d0695ca1238b22da4ae784a9a58e11a Mon Sep 17 00:00:00 2001 From: Ola Saadi Date: Thu, 31 Oct 2024 17:19:55 +0200 Subject: [PATCH] fix lint --- pkg/common/strings.go | 7 +++---- pkg/commonvpc/sg_analysis.go | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/common/strings.go b/pkg/common/strings.go index d0b9fc3a8..36bd30ad1 100644 --- a/pkg/common/strings.go +++ b/pkg/common/strings.go @@ -1,5 +1,6 @@ /* Copyright 2023- IBM Inc. All Rights Reserved. + SPDX-License-Identifier: Apache-2.0 */ @@ -21,9 +22,8 @@ const ( NoConnections = "No Connections" ) const ( - spaceString = " " - protocolString = "protocol: " - // commaString = ", " + spaceString = " " + protocolString = "protocol: " semicolonString = "; " ) @@ -61,7 +61,6 @@ func getTCPUDPCubeStr(cube ds.Triple[*netset.ProtocolSet, *netset.PortSet, *nets } func getICMPCubeStr(cube ds.Pair[*netset.TypeSet, *netset.CodeSet]) string { - // tc := cube.ICMPTypeCode() if cube.Left.Equal(netset.AllICMPTypes()) && cube.Right.Equal(netset.AllICMPCodes()) { return "" } diff --git a/pkg/commonvpc/sg_analysis.go b/pkg/commonvpc/sg_analysis.go index 1124a6ab9..d3c445287 100644 --- a/pkg/commonvpc/sg_analysis.go +++ b/pkg/commonvpc/sg_analysis.go @@ -211,7 +211,8 @@ func (sga *SGAnalyzer) allowedConnectivity(target, local *netset.IPBlock, isIngr // 2. If connection is part of the query: is the required connection contained in the existing connection? // if it does, then the contributing rules are detected: rules that intersect the required connection // otherwise, the answer to the query is "no" and nil is returned -func (sga *SGAnalyzer) rulesFilterInConnectivity(target, local *netset.IPBlock, connQuery *netset.TransportSet, isIngress bool) ([]int, error) { +func (sga *SGAnalyzer) rulesFilterInConnectivity(target, local *netset.IPBlock, + connQuery *netset.TransportSet, isIngress bool) ([]int, error) { analyzedConnsMap := sga.ingressOrEgressConnectivity(isIngress) for definedLocal, analyzedConns := range analyzedConnsMap { if local.IsSubset(definedLocal) {