Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consume from the collector the ResourcesContainter #134

Closed
adisos opened this issue Aug 9, 2023 · 2 comments · Fixed by #283
Closed

consume from the collector the ResourcesContainter #134

adisos opened this issue Aug 9, 2023 · 2 comments · Fixed by #283
Assignees
@adisos
Labels
code re-org

Comments

@adisos
Copy link
Collaborator

adisos commented Aug 9, 2023 •
edited
Loading

Currently parser generates the ResourcesContainer from the input config object.
Now the collector supports the creation of this object, thus should use the collector's object instead.
@adisos adisos self-assigned this Aug 9, 2023
@adisos adisos changed the title move parser and ResourcesContainter to a separate package consume from the collector the ResourcesContainter Dec 12, 2023
@adisos
Copy link
Collaborator Author

adisos commented Dec 19, 2023

opened a related issue, while trying to unmarshal input json to the collector's resources container:
np-guard/cloud-resource-collector#163

(it did not fail in the current analyzer's unmarshal function).

adisos added a commit that referenced this issue Dec 19, 2023
@adisos
issue #134 - wip
b961e9a 
Signed-off-by: adisos <[email protected]>
@adisos
Copy link
Collaborator Author

adisos commented Dec 19, 2023

this issue's branch: https://github.com/np-guard/vpc-network-config-analyzer/tree/issue_134

adisos added a commit that referenced this issue Dec 19, 2023
@adisos
issue #134 - wip
c09c2e0 
Signed-off-by: adisos <[email protected]>
adisos added a commit that referenced this issue Dec 19, 2023
@adisos
issue #134 - wip
9c4d79a 
Signed-off-by: adisos <[email protected]>
@adisos adisos linked a pull request Dec 19, 2023 that will close this issue
Issue 134 - consume from the collector the ResourcesContainter #283
Merged
adisos added a commit that referenced this issue Dec 27, 2023
@adisos
issue #134 - wip
ccf630d 
Signed-off-by: adisos <[email protected]>
adisos added a commit that referenced this issue Jan 1, 2024
@adisos
issue #134 - wip
8f17912 
Signed-off-by: adisos <[email protected]>
adisos added a commit that referenced this issue Jan 11, 2024
@adisos
issue #134 - wip
c71d608 
Signed-off-by: adisos <[email protected]>
adisos added a commit that referenced this issue Jan 15, 2024
@adisos
Issue 134 - consume from the collector the ResourcesContainter (#283)
fab6432 
* issue #134 - wip

Signed-off-by: adisos <[email protected]>

* remove temp comment on certain tests

Signed-off-by: adisos <[email protected]>

* remove generated files from test of main

Signed-off-by: adisos <[email protected]>

* remove temporary test file

Signed-off-by: adisos <[email protected]>

---------

Signed-off-by: adisos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adisos adisos

Labels
code re-org
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 134 - consume from the collector the ResourcesContainter np-guard/vpc-network-config-analyzer
1 participant
@adisos