subnet-grouping2 #245
Merged
subnet-grouping2 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivnevo
requested changes
Dec 4, 2023
ShiriMoran
reviewed
Dec 6, 2023
There was a problem hiding this comment.
@haim-kermany I've put some initial comments. Will still need to take it off line to get some basic understanding.
olasaadi99
pushed a commit
that referenced
this pull request
Jan 4, 2024
* init * go 20 * go 20 * not 1.2 * ShowOnSubnetMode for tgw * use go-version-file * CR from Ziv * removing subnetMode flag * does not work * another try * change subnetmode Location * test * lint * code review * documenting * using maps from golang 21 * code review * not use pointer to map * handle pointers to string * adding tests to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git did not agree with the previews one.
Adi, please review the vpcmodel\ibmvpc parts