Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect explainConnectivity to main cli #326

Merged
merged 12 commits into from
Jan 22, 2024
Merged

connect explainConnectivity to main cli #326

merged 12 commits into from
Jan 22, 2024

Conversation

olasaadi99
Copy link
Contributor

No description provided.

@olasaadi99 olasaadi99 requested a review from ShiriMoran January 16, 2024 14:02
@olasaadi99 olasaadi99 linked an issue Jan 16, 2024 that may be closed by this pull request
Connect explainability to CLI #321
Closed
@olasaadi99 olasaadi99 marked this pull request as ready for review January 16, 2024 14:27
ShiriMoran
ShiriMoran requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ShiriMoran ShiriMoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please call

cmd/analyzer/main.go Show resolved Hide resolved
ShiriMoran
ShiriMoran requested changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@ShiriMoran ShiriMoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please see my few comments; also merge with the latest branch

cmd/analyzer/main.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/vpcmodel/output.go Outdated Show resolved Hide resolved
ShiriMoran
ShiriMoran requested changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@ShiriMoran ShiriMoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add end-to-end test with conn queried

cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
adisos
adisos requested changes Jan 21, 2024
View reviewed changes
cmd/analyzer/parse_args.go Outdated Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Show resolved Hide resolved
pkg/vpcmodel/nodesExplainability.go Outdated Show resolved Hide resolved
pkg/ibmvpc/analysis_output_test.go Show resolved Hide resolved
pkg/ibmvpc/analysis_output_test.go Outdated Show resolved Hide resolved
adisos
adisos previously approved these changes Jan 21, 2024
View reviewed changes
@olasaadi99 olasaadi99 requested a review from ShiriMoran January 21, 2024 15:08
ShiriMoran
ShiriMoran reviewed Jan 21, 2024
View reviewed changes
pkg/vpcmodel/output.go Outdated Show resolved Hide resolved
ShiriMoran
ShiriMoran previously approved these changes Jan 21, 2024
View reviewed changes
@olasaadi99 olasaadi99 dismissed stale reviews from ShiriMoran and adisos via b22f90d January 21, 2024 16:12
@ShiriMoran ShiriMoran merged commit 11c8732 into main Jan 22, 2024
4 checks passed
@ShiriMoran ShiriMoran deleted the 321_explainability branch January 22, 2024 06:10
@ShiriMoran ShiriMoran mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

@ShiriMoran ShiriMoran ShiriMoran left review comments

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect explainability to CLI
3 participants
@olasaadi99 @adisos @ShiriMoran