Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1938. It depends on the changes in npgsql/npgsql#3867.
This is currently pretty rough and incomplete but I'm putting it up as a draft for visibility. It's my first dive into working with EF Core database provider implementations so feel free to point out anything I'm doing wrong.
Current API as of e130ecd:
cube && cube
bool Overlaps(this NpgsqlCube a, NpgsqlCube b)
cube @> cube
bool Contains(this NpgsqlCube a, NpgsqlCube b)
cube <@ cube
bool ContainedBy(this NpgsqlCube a, NpgsqlCube b)
cube -> integer
double NthCoordinate(this NpgsqlCube cube, int n)
cube ~> integer
double NthCoordinate2(this NpgsqlCube cube, int n)
cube <-> cube
double Distance(this NpgsqlCube a, NpgsqlCube b)
cube <#> cube
double DistanceTaxicab(this NpgsqlCube a, NpgsqlCube b)
cube <=> cube
double DistanceChebyshev(this NpgsqlCube a, NpgsqlCube b)
cube_union(cube, cube)
NpgsqlCube Union(this NpgsqlCube a, NpgsqlCube b)
cube_inter(cube, cube)
NpgsqlCube Intersect(this NpgsqlCube a, NpgsqlCube b)
cube_enlarge(c cube, r double, n integer)
NpgsqlCube Enlarge(this NpgsqlCube cube, double r, int n)
cube_dim(cube)
int Dimensions
cube_ll_coord(cube, integer)
double LlCoord(int n)
cube_ur_coord(cube, integer)
double UrCoord(int n)
cube_is_point(cube)
bool Point
cube_subset(cube, integer[])
NpgsqlCube Subset(params int[] indexes)
Looking for feedback on these points:
NthCoordinate2
that differentiates it fromNthCoordinate
. Maybe shortenCoordinate
toCoord
to be consistent withLlCoord
andUrCoord
?NpgsqlCube.LowerLeft
andNpgsqlCube.UpperRight
or only supporting theLlCoord
andUrCoord
methods.