-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: devEngines #7766
feat: devEngines #7766
Conversation
What happens without |
Hey @ljharb, it works as it should. Is this in reference to the description or something you saw in the code? |
No, just from reading your OP - the implication is that |
As per the spec it fails if |
ah ok, so if i don't want to use |
One additional consideration - only in CI, you'd explicitly need it to not fail (because devEngines might say "node 22" but engines might say "node 18, 20, or 22", and you'd want to be testing on all 3 majors). How could I set that only in CI, if there's no env var or npmrc config to do that? |
If you support node 18, 20, or 22 then |
That's not the intended usage of the field, though - otherwise |
I updated the description with some clarifications on |
Your OP looks great! What I was trying to convey is that, for typical and desired CI usage, there needs to be an npm config-based mechanism to change "fail" to "warn" or "none" (or, to cause it to look at the union of engines + devEngines instead and THEN fail - which might be even better!) |
If you are testing something in CI why are you setting devEngines outside the bounds of where you test it? |
@wraithgar for a package, CI is for testing what |
Makes sense. That's a whole larger discussion in npm itself in "how do I interact with this code base as if it were a package being used elsewhere". I don't think it's a blocker for this feature. |
It's a blocker for its use in packages, but certainly not one for its use in applications. It would be very nice for the initial implementation to have an answer for this, though - and my suggestion is either an npm config (and thus an env var) that can override "fail" to "warn", and/or, an npm config (and thus an env var) for checking the union of engines and devEngines before failing/warning/etc. |
That's a much bigger feature than you think. It effectively means "npm please interact with this top level package.json as if it were a package you are installing" which means parsing engines, os, etc differently. If this is something you need to do then you are much better off doing something like Tacking on a "ok just ignore devEngines" flag masks the reality of this disconnect. ETA: Even the lifecycle scripts act differently when you are installing as a package. Again this is a much bigger issue than just devEngines. |
Fair that it may be large enough of a change to need doing in a separate effort - but "pack in CI and test the output of the tarball" is wildly impractical and incredible difficult to achieve (because of how tests are written), so i don't think that's a viable alternative. npm already parses |
PRs welcome. |
Great, after this lands I'll submit one :-) |
Possibly related to @ljharb's comments, what kind of |
Because we're still operating on a widely popular runtime / packageManager I don't see much value in adding it, but if we were to add {
"devEngines": {
"runtime": {
"name": "node",
"version": ">10.0.0",
"onFail": "error"
},
"packageManager": {
"name": "npm",
"version": ">10.0.0",
"onFail": "error"
}
}
} |
Thanks @reggi. In practice I think you'd need a newer version of node for development tasks like running |
Some thoughts on
In CI, codebases support old versions of Node.js. For example, node-semver's |
As I explained upthread, the only reason for devEngines to exist is so it can be a subset of npm already does some things automatically in CI when certain env vars are present; it seems pretty reasonable to me to default that flag to |
The point of The point of
Maybe it's not for you, if you're just gonna use node / npm.
I think |
It's true that |
c7802c9
to
4fedafb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Following up on a few minor things before I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some minor non-blocking feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving to get things moving since the last feedback was "nonblocking"
##### [`v10.9.0](https://github.com/npm/cli/blob/HEAD/CHANGELOG.md#1090-2024-10-03) ##### Features - [`4d57928`](npm/cli@4d57928) [#7766](npm/cli#7766) devEngines ([#7766](npm/cli#7766)) ([@reggi](https://github.com/reggi)) ##### Bug Fixes - [`6ca609e`](npm/cli@6ca609e) [#7789](npm/cli#7789) ping and doctor commands fix for checking if registry is online ([#7789](npm/cli#7789)) ([@milaninfy](https://github.com/milaninfy)) ##### Documentation - [`63d6a73`](npm/cli@63d6a73) [#7783](npm/cli#7783) package.json: add brief section on exports, link to Node.js docs ([#7783](npm/cli#7783)) ([@wheresrhys](https://github.com/wheresrhys)) - [`366c07e`](npm/cli@366c07e) [#7776](npm/cli#7776) remove incorrect note about npm install ([#7776](npm/cli#7776)) ([@wraithgar](https://github.com/wraithgar)) ##### Dependencies - [`60a7ee5`](npm/cli@60a7ee5) [#7803](npm/cli#7803) hoist npm-normalize-package-bin - [`20dd44f`](npm/cli@20dd44f) [#7803](npm/cli#7803) hoist minipass-fetch - [`5795987`](npm/cli@5795987) [#7803](npm/cli#7803) update `[email protected]` - [`99ccae3`](npm/cli@99ccae3) [#7803](npm/cli#7803) update `[email protected]` - [`75786ad`](npm/cli@75786ad) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`1c25a1d`](npm/cli@1c25a1d) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`2d7fc3d`](npm/cli@2d7fc3d) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`1e09334`](npm/cli@1e09334) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`820e983`](npm/cli@820e983) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`9cd6603`](npm/cli@9cd6603) [#7803](npm/cli#7803) update `[email protected]` - [`b84d907`](npm/cli@b84d907) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`53ed632`](npm/cli@53ed632) [#7803](npm/cli#7803) update `[email protected]` - [`ab40dab`](npm/cli@ab40dab) [#7803](npm/cli#7803) update `[email protected]` - [`b1c4770`](npm/cli@b1c4770) [#7803](npm/cli#7803) update `[email protected]` - [`8206c4f`](npm/cli@8206c4f) [#7803](npm/cli#7803) update `[email protected]` - [`8b7dbc8`](npm/cli@8b7dbc8) [#7803](npm/cli#7803) update `[email protected]` - [`f6909a0`](npm/cli@f6909a0) [#7803](npm/cli#7803) update `[email protected]` - [`f9b2e18`](npm/cli@f9b2e18) [#7803](npm/cli#7803) update `[email protected]` - [`e7ab206`](npm/cli@e7ab206) [#7803](npm/cli#7803) update `[email protected]` - [`b28dbb1`](npm/cli@b28dbb1) [#7803](npm/cli#7803) update `[email protected]` - [`d13a20b`](npm/cli@d13a20b) [#7803](npm/cli#7803) update `[email protected]` - [`5208f74`](npm/cli@5208f74) [#7803](npm/cli#7803) update `[email protected]` - [`092f41f`](npm/cli@092f41f) [#7803](npm/cli#7803) update `[email protected]` - [`50a7bc8`](npm/cli@50a7bc8) [#7803](npm/cli#7803) update `[email protected]` - [`591130d`](npm/cli@591130d) [#7803](npm/cli#7803) update `[email protected]` - [`be6ae96`](npm/cli@be6ae96) [#7803](npm/cli#7803) update `[email protected]` - [`8d4060a`](npm/cli@8d4060a) [#7803](npm/cli#7803) update `[email protected]` - [`105fa2b`](npm/cli@105fa2b) [#7803](npm/cli#7803) update `[email protected]` - [`eae4f57`](npm/cli@eae4f57) [#7803](npm/cli#7803) update `[email protected]` - [`7214149`](npm/cli@7214149) [#7803](npm/cli#7803) update `[email protected]` - [`c4bed31`](npm/cli@c4bed31) [#7803](npm/cli#7803) update `[email protected]` - [`f54b155`](npm/cli@f54b155) [#7803](npm/cli#7803) update `[email protected]` - [`6deae9e`](npm/cli@6deae9e) [#7803](npm/cli#7803) update `[email protected]` - [`034c729`](npm/cli@034c729) [#7803](npm/cli#7803) update `[email protected]` - [`ddb8be0`](npm/cli@ddb8be0) [#7803](npm/cli#7803) update `[email protected]` - [`538a4cc`](npm/cli@538a4cc) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`b80d048`](npm/cli@b80d048) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`81137fc`](npm/cli@81137fc) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`2076368`](npm/cli@2076368) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`feac87c`](npm/cli@feac87c) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`dd90f9e`](npm/cli@dd90f9e) [#7803](npm/cli#7803) update `@npmcli/[email protected]` ##### Chores - [`95e2cb1`](npm/cli@95e2cb1) [#7810](npm/cli#7810) ignore .github folder in release-please ([@reggi](https://github.com/reggi)) - [`be1e6da`](npm/cli@be1e6da) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`43f2374`](npm/cli@43f2374) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`bb03036`](npm/cli@bb03036) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`2072705`](npm/cli@2072705) [#7803](npm/cli#7803) update `@npmcli/[email protected]` ([@reggi](https://github.com/reggi)) - [`949d8f8`](npm/cli@949d8f8) [#7803](npm/cli#7803) engine ^18.17.0 || >=20.5.0 in package template ([@reggi](https://github.com/reggi)) - [`fefd509`](npm/cli@fefd509) [#7764](npm/cli#7764) deps: bump actions/download-artifact from 3 to 4 in /.github/workflows ([#7764](npm/cli#7764)) ([@dependabot](https://github.com/dependabot)\[bot], [@wraithgar](https://github.com/wraithgar)) - [workspace](https://github.com/npm/cli/releases/tag/arborist-v8.0.0): `@npmcli/[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/config-v9.0.0): `@npmcli/[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmaccess-v9.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmdiff-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmexec-v9.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmfund-v6.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmhook-v11.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmorg-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmpack-v8.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmpublish-v10.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmsearch-v8.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmteam-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmversion-v7.0.0): `[email protected]`
##### [`v10.9.0](https://github.com/npm/cli/blob/HEAD/CHANGELOG.md#1090-2024-10-03) ##### Features - [`4d57928`](npm/cli@4d57928) [#7766](npm/cli#7766) devEngines ([#7766](npm/cli#7766)) ([@reggi](https://github.com/reggi)) ##### Bug Fixes - [`6ca609e`](npm/cli@6ca609e) [#7789](npm/cli#7789) ping and doctor commands fix for checking if registry is online ([#7789](npm/cli#7789)) ([@milaninfy](https://github.com/milaninfy)) ##### Documentation - [`63d6a73`](npm/cli@63d6a73) [#7783](npm/cli#7783) package.json: add brief section on exports, link to Node.js docs ([#7783](npm/cli#7783)) ([@wheresrhys](https://github.com/wheresrhys)) - [`366c07e`](npm/cli@366c07e) [#7776](npm/cli#7776) remove incorrect note about npm install ([#7776](npm/cli#7776)) ([@wraithgar](https://github.com/wraithgar)) ##### Dependencies - [`60a7ee5`](npm/cli@60a7ee5) [#7803](npm/cli#7803) hoist npm-normalize-package-bin - [`20dd44f`](npm/cli@20dd44f) [#7803](npm/cli#7803) hoist minipass-fetch - [`5795987`](npm/cli@5795987) [#7803](npm/cli#7803) update `[email protected]` - [`99ccae3`](npm/cli@99ccae3) [#7803](npm/cli#7803) update `[email protected]` - [`75786ad`](npm/cli@75786ad) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`1c25a1d`](npm/cli@1c25a1d) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`2d7fc3d`](npm/cli@2d7fc3d) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`1e09334`](npm/cli@1e09334) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`820e983`](npm/cli@820e983) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`9cd6603`](npm/cli@9cd6603) [#7803](npm/cli#7803) update `[email protected]` - [`b84d907`](npm/cli@b84d907) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`53ed632`](npm/cli@53ed632) [#7803](npm/cli#7803) update `[email protected]` - [`ab40dab`](npm/cli@ab40dab) [#7803](npm/cli#7803) update `[email protected]` - [`b1c4770`](npm/cli@b1c4770) [#7803](npm/cli#7803) update `[email protected]` - [`8206c4f`](npm/cli@8206c4f) [#7803](npm/cli#7803) update `[email protected]` - [`8b7dbc8`](npm/cli@8b7dbc8) [#7803](npm/cli#7803) update `[email protected]` - [`f6909a0`](npm/cli@f6909a0) [#7803](npm/cli#7803) update `[email protected]` - [`f9b2e18`](npm/cli@f9b2e18) [#7803](npm/cli#7803) update `[email protected]` - [`e7ab206`](npm/cli@e7ab206) [#7803](npm/cli#7803) update `[email protected]` - [`b28dbb1`](npm/cli@b28dbb1) [#7803](npm/cli#7803) update `[email protected]` - [`d13a20b`](npm/cli@d13a20b) [#7803](npm/cli#7803) update `[email protected]` - [`5208f74`](npm/cli@5208f74) [#7803](npm/cli#7803) update `[email protected]` - [`092f41f`](npm/cli@092f41f) [#7803](npm/cli#7803) update `[email protected]` - [`50a7bc8`](npm/cli@50a7bc8) [#7803](npm/cli#7803) update `[email protected]` - [`591130d`](npm/cli@591130d) [#7803](npm/cli#7803) update `[email protected]` - [`be6ae96`](npm/cli@be6ae96) [#7803](npm/cli#7803) update `[email protected]` - [`8d4060a`](npm/cli@8d4060a) [#7803](npm/cli#7803) update `[email protected]` - [`105fa2b`](npm/cli@105fa2b) [#7803](npm/cli#7803) update `[email protected]` - [`eae4f57`](npm/cli@eae4f57) [#7803](npm/cli#7803) update `[email protected]` - [`7214149`](npm/cli@7214149) [#7803](npm/cli#7803) update `[email protected]` - [`c4bed31`](npm/cli@c4bed31) [#7803](npm/cli#7803) update `[email protected]` - [`f54b155`](npm/cli@f54b155) [#7803](npm/cli#7803) update `[email protected]` - [`6deae9e`](npm/cli@6deae9e) [#7803](npm/cli#7803) update `[email protected]` - [`034c729`](npm/cli@034c729) [#7803](npm/cli#7803) update `[email protected]` - [`ddb8be0`](npm/cli@ddb8be0) [#7803](npm/cli#7803) update `[email protected]` - [`538a4cc`](npm/cli@538a4cc) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`b80d048`](npm/cli@b80d048) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`81137fc`](npm/cli@81137fc) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`2076368`](npm/cli@2076368) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`feac87c`](npm/cli@feac87c) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`dd90f9e`](npm/cli@dd90f9e) [#7803](npm/cli#7803) update `@npmcli/[email protected]` ##### Chores - [`95e2cb1`](npm/cli@95e2cb1) [#7810](npm/cli#7810) ignore .github folder in release-please ([@reggi](https://github.com/reggi)) - [`be1e6da`](npm/cli@be1e6da) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`43f2374`](npm/cli@43f2374) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`bb03036`](npm/cli@bb03036) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`2072705`](npm/cli@2072705) [#7803](npm/cli#7803) update `@npmcli/[email protected]` ([@reggi](https://github.com/reggi)) - [`949d8f8`](npm/cli@949d8f8) [#7803](npm/cli#7803) engine ^18.17.0 || >=20.5.0 in package template ([@reggi](https://github.com/reggi)) - [`fefd509`](npm/cli@fefd509) [#7764](npm/cli#7764) deps: bump actions/download-artifact from 3 to 4 in /.github/workflows ([#7764](npm/cli#7764)) ([@dependabot](https://github.com/dependabot)\[bot], [@wraithgar](https://github.com/wraithgar)) - [workspace](https://github.com/npm/cli/releases/tag/arborist-v8.0.0): `@npmcli/[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/config-v9.0.0): `@npmcli/[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmaccess-v9.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmdiff-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmexec-v9.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmfund-v6.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmhook-v11.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmorg-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmpack-v8.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmpublish-v10.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmsearch-v8.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmteam-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmversion-v7.0.0): `[email protected]`
##### [`v10.9.0](https://github.com/npm/cli/blob/HEAD/CHANGELOG.md#1090-2024-10-03) ##### Features - [`4d57928`](npm/cli@4d57928) [#7766](npm/cli#7766) devEngines ([#7766](npm/cli#7766)) ([@reggi](https://github.com/reggi)) ##### Bug Fixes - [`6ca609e`](npm/cli@6ca609e) [#7789](npm/cli#7789) ping and doctor commands fix for checking if registry is online ([#7789](npm/cli#7789)) ([@milaninfy](https://github.com/milaninfy)) ##### Documentation - [`63d6a73`](npm/cli@63d6a73) [#7783](npm/cli#7783) package.json: add brief section on exports, link to Node.js docs ([#7783](npm/cli#7783)) ([@wheresrhys](https://github.com/wheresrhys)) - [`366c07e`](npm/cli@366c07e) [#7776](npm/cli#7776) remove incorrect note about npm install ([#7776](npm/cli#7776)) ([@wraithgar](https://github.com/wraithgar)) ##### Dependencies - [`60a7ee5`](npm/cli@60a7ee5) [#7803](npm/cli#7803) hoist npm-normalize-package-bin - [`20dd44f`](npm/cli@20dd44f) [#7803](npm/cli#7803) hoist minipass-fetch - [`5795987`](npm/cli@5795987) [#7803](npm/cli#7803) update `[email protected]` - [`99ccae3`](npm/cli@99ccae3) [#7803](npm/cli#7803) update `[email protected]` - [`75786ad`](npm/cli@75786ad) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`1c25a1d`](npm/cli@1c25a1d) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`2d7fc3d`](npm/cli@2d7fc3d) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`1e09334`](npm/cli@1e09334) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`820e983`](npm/cli@820e983) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`9cd6603`](npm/cli@9cd6603) [#7803](npm/cli#7803) update `[email protected]` - [`b84d907`](npm/cli@b84d907) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`53ed632`](npm/cli@53ed632) [#7803](npm/cli#7803) update `[email protected]` - [`ab40dab`](npm/cli@ab40dab) [#7803](npm/cli#7803) update `[email protected]` - [`b1c4770`](npm/cli@b1c4770) [#7803](npm/cli#7803) update `[email protected]` - [`8206c4f`](npm/cli@8206c4f) [#7803](npm/cli#7803) update `[email protected]` - [`8b7dbc8`](npm/cli@8b7dbc8) [#7803](npm/cli#7803) update `[email protected]` - [`f6909a0`](npm/cli@f6909a0) [#7803](npm/cli#7803) update `[email protected]` - [`f9b2e18`](npm/cli@f9b2e18) [#7803](npm/cli#7803) update `[email protected]` - [`e7ab206`](npm/cli@e7ab206) [#7803](npm/cli#7803) update `[email protected]` - [`b28dbb1`](npm/cli@b28dbb1) [#7803](npm/cli#7803) update `[email protected]` - [`d13a20b`](npm/cli@d13a20b) [#7803](npm/cli#7803) update `[email protected]` - [`5208f74`](npm/cli@5208f74) [#7803](npm/cli#7803) update `[email protected]` - [`092f41f`](npm/cli@092f41f) [#7803](npm/cli#7803) update `[email protected]` - [`50a7bc8`](npm/cli@50a7bc8) [#7803](npm/cli#7803) update `[email protected]` - [`591130d`](npm/cli@591130d) [#7803](npm/cli#7803) update `[email protected]` - [`be6ae96`](npm/cli@be6ae96) [#7803](npm/cli#7803) update `[email protected]` - [`8d4060a`](npm/cli@8d4060a) [#7803](npm/cli#7803) update `[email protected]` - [`105fa2b`](npm/cli@105fa2b) [#7803](npm/cli#7803) update `[email protected]` - [`eae4f57`](npm/cli@eae4f57) [#7803](npm/cli#7803) update `[email protected]` - [`7214149`](npm/cli@7214149) [#7803](npm/cli#7803) update `[email protected]` - [`c4bed31`](npm/cli@c4bed31) [#7803](npm/cli#7803) update `[email protected]` - [`f54b155`](npm/cli@f54b155) [#7803](npm/cli#7803) update `[email protected]` - [`6deae9e`](npm/cli@6deae9e) [#7803](npm/cli#7803) update `[email protected]` - [`034c729`](npm/cli@034c729) [#7803](npm/cli#7803) update `[email protected]` - [`ddb8be0`](npm/cli@ddb8be0) [#7803](npm/cli#7803) update `[email protected]` - [`538a4cc`](npm/cli@538a4cc) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`b80d048`](npm/cli@b80d048) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`81137fc`](npm/cli@81137fc) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`2076368`](npm/cli@2076368) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`feac87c`](npm/cli@feac87c) [#7803](npm/cli#7803) update `@npmcli/[email protected]` - [`dd90f9e`](npm/cli@dd90f9e) [#7803](npm/cli#7803) update `@npmcli/[email protected]` ##### Chores - [`95e2cb1`](npm/cli@95e2cb1) [#7810](npm/cli#7810) ignore .github folder in release-please ([@reggi](https://github.com/reggi)) - [`be1e6da`](npm/cli@be1e6da) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`43f2374`](npm/cli@43f2374) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`bb03036`](npm/cli@bb03036) [#7803](npm/cli#7803) update `[email protected]` ([@reggi](https://github.com/reggi)) - [`2072705`](npm/cli@2072705) [#7803](npm/cli#7803) update `@npmcli/[email protected]` ([@reggi](https://github.com/reggi)) - [`949d8f8`](npm/cli@949d8f8) [#7803](npm/cli#7803) engine ^18.17.0 || >=20.5.0 in package template ([@reggi](https://github.com/reggi)) - [`fefd509`](npm/cli@fefd509) [#7764](npm/cli#7764) deps: bump actions/download-artifact from 3 to 4 in /.github/workflows ([#7764](npm/cli#7764)) ([@dependabot](https://github.com/dependabot)\[bot], [@wraithgar](https://github.com/wraithgar)) - [workspace](https://github.com/npm/cli/releases/tag/arborist-v8.0.0): `@npmcli/[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/config-v9.0.0): `@npmcli/[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmaccess-v9.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmdiff-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmexec-v9.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmfund-v6.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmhook-v11.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmorg-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmpack-v8.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmpublish-v10.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmsearch-v8.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmteam-v7.0.0): `[email protected]` - [workspace](https://github.com/npm/cli/releases/tag/libnpmversion-v7.0.0): `[email protected]`
What happens when |
npm treats that as There are no plans for npm to automatically download via this spec. |
Adds new "devEngines" field to package.json type. This would wait for this to land in the cli and be released. npm/cli#7766
This PR adds a check for
devEngines
in the current projectspackage.json
as defined in the spec here:openjs-foundation/package-metadata-interoperability-collab-space#15
This PR utilizes a
checkDevEngines
function defined withinnpm-install-checks
open here:npm/npm-install-checks#116
The goal of this pr is to have a check for specific npm commands
install
, andrun
consult thedevEngines
property before execution and check if the current system / environment. Fornpm
the runtime will always benode
and thepackageManager
will always benpm
, if a project is defined as not those two envs and it's required we'll throw.