feat!: adds --ignore-scripts flag to pack #7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
force-pushed
the
reggi/ignore-scripts4
branch
3 times, most recently
from
4f26f54 to
9fa1577
Compare
reggi
force-pushed
the
reggi/ignore-scripts4
branch
2 times, most recently
from
f16df11 to
4a2e481
Compare
reggi
force-pushed
the
reggi/ignore-scripts4
branch
from
4a2e481 to
ecd2d23
Compare
reggi
force-pushed
the
reggi/ignore-scripts4
branch
from
4e3c911 to
72fa7ad
Compare
reggi
force-pushed
the
reggi/ignore-scripts4
branch
3 times, most recently
from
55b04b0 to
0b6941e
Compare
BREAKING CHANGE: `--ignore-scripts` now applies to all lifecycle scripts, include `prepare`
reggi
force-pushed
the
reggi/ignore-scripts4
branch
from
0b6941e to
29e37be
Compare
wraithgar
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pr bumps
pacotewhich will honorignoreScriptsopt passed in through the cli. In addition it adds--ignore-scriptsas a flag to the pack command ignore thepreparescript.Why
People expect
--ignore-scriptsto... ignore the lifecycle scripts in package.json, which it does for all lifecycle scripts except forprepare, which runs duringpack, andpublish.integrating: npm/pacote#407
from: #7211
part of: npm/statusboard#898