Update traffic join to avoid 'traffic evaporating'

[Robinlovelace]

There are small anomalies popping up e.g.:

https://osm.org/go/evfLeWTk?m=

It appears if the traffic is evaporating between these two high-flow section. There were a couple of other examples of this that occur if you need me to send them across too.

[Robinlovelace]

It's there in the traffic data:

[Robinlovelace]

Source: output of this:

> newhaven = zonebuilder::zb_zone("newhaven edinburgh")
> traffic_newhaven = traffic_volumes_scotland[newhaven, ]
nrow(traffic_> nrow(traffic_newhaven)
[1] 22672
> newhaven = zonebuilder::zb_zone("newhaven edinburgh", n_circles = 1)
Please set segment_center = TRUE to divide the centre into multiple segments
> traffic_newhaven = traffic_volumes_scotland[newhaven, ]
> mapview::mapview(traffic_newhaven, zcol = "pred_flows")
Browsing http://127.0.0.1:7996

[Robinlovelace]

But the segment is totally missing from the CBD layer:

Source: https://nptscot.github.io/#/clos/#14.21/55.97816/-3.2004

[wangzhao0217]

error stem from this line:

osm_district = osm_national |>
        filter(osm_id %in% district_centroids$osm_id)

[wangzhao0217]

Can be fix by using:

      osm_district = osm_national[sf::st_union(district_geom), , op = sf::st_intersects]

but it is slow

[Robinlovelace]

Great diagnosis of the issue, thanks Zhao!

[Robinlovelace]

I think a better solution would be to update the LAD boundaries file. We could add a simple buffer but that would cause duplicates. I have an idea...

[Robinlovelace]

Can be fix by using:

      osm_district = osm_national[sf::st_union(district_geom), , op = sf::st_intersects]

Another issue with that solution: it will lead to duplicate IDs. A reason for using centroids is you only get 1 per region.

[Robinlovelace]

I'm on the case: I think I can come up with a quick fix to the LADs.

[Robinlovelace]

Fix in progress:

[Robinlovelace]

That section is mostly fixed:

[Robinlovelace]

Source: https://nptscot.github.io/#/clos/#13.9/55.98072/-3.20461

[Robinlovelace]

Still a tiny bit missing:

[Robinlovelace]

Source: https://nptscot.github.io/#/clos/#15.84/55.980376/-3.202827

[Robinlovelace]

It is covered by the new region boundary introduced in #557:

Source:

inputdata git:(main) ✗ qgis boundaries/la_regions_scotland_bfe_simplified_2023.geojson

[Robinlovelace]

Should be fixed upstream in nptscot/osmactive#66

[Robinlovelace]

Fixed in #550