Improve sequence point coverage for debug info #3639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
reviewed
Oct 22, 2024
There was a problem hiding this comment.
And please, read and follow our contribution guidelines: https://github.com/nspcc-dev/.github/blob/master/git.md#commits
| @@ -662,6 +662,7 @@ func (c *codegen) Visit(node ast.Node) ast.Visitor { | |||
| return nil | |||
|
|
|||
| case *ast.AssignStmt: | |||
| c.saveSequencePoint(n) | |||
There was a problem hiding this comment.
We need a lot of tests for it. It's easy to place these missing lines of code to every AST node handler, I don't need an issue for that. But it's not a solution. What we need is to ensure that the resulting sequence points are:
- Properly generated and match the expectations.
- There are no duplicating sequence points.
- Match (or at least relatively match) the corresponding C# debugger output for similar AST nodes.
- There are no more statements that don't have corresponding sequence points.
|
Unmaintained. Feel free to reopen if you have any updates wrt review comments left here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #3618
...
Solution
saveSequencePointcalls for various AST node types....