Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover example contracts with tests #3648

Open
AnnaShaleva opened this issue Oct 28, 2024 · 1 comment
Open

Cover example contracts with tests #3648

AnnaShaleva opened this issue Oct 28, 2024 · 1 comment
Labels
enhancement Improving existing functionality good first issue Good for newcomers help wanted Extra attention is needed I2 Regular impact S4 Routine test Unit tests U4 Nothing urgent
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

Some of our example contracts are not tested although they are complicated. In fact, only NNS contract has some unit-tests.

Describe the solution you'd like

At least complicated contracts like nft-nd and nft-d must be covered with neotest unit tests. Ideally, all of them must be covered with tests. First of all, these contracts are examples for other SC developers. Secondly, when we extend these contracts, we need to have a way to check that extension works properly, e.g. for situations like in #3560.

Describe alternatives you've considered

No alternatives, tests are must-have.

@AnnaShaleva AnnaShaleva added I3 Minimal impact test Unit tests U4 Nothing urgent enhancement Improving existing functionality S4 Routine labels Oct 28, 2024
@roman-khimov roman-khimov added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 21, 2024
@AnnaShaleva
Copy link
Member Author

Ping to this issue, there's a demand from user side to see how neotest works, and currently we can only provide NNS tests as an example. It's always good when we can provide more examples on how to use neotest.

@AnnaShaleva AnnaShaleva added this to the v0.108.0 milestone Dec 9, 2024
@AnnaShaleva AnnaShaleva added I2 Regular impact and removed I3 Minimal impact labels Dec 9, 2024
@AnnaShaleva AnnaShaleva modified the milestones: v0.107.2, v0.108.0 Dec 13, 2024
@roman-khimov roman-khimov modified the milestones: v0.108.0, v0.110.0 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality good first issue Good for newcomers help wanted Extra attention is needed I2 Regular impact S4 Routine test Unit tests U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants