Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traverseiterator RPC server test is failing on fresh chain #3671

Closed
AnnaShaleva opened this issue Nov 11, 2024 · 0 comments · Fixed by #3680
Closed

traverseiterator RPC server test is failing on fresh chain #3671

AnnaShaleva opened this issue Nov 11, 2024 · 0 comments · Fixed by #3680
Labels
bug Something isn't working I4 No visible changes S4 Routine test Unit tests U2 Seriously planned
Milestone

Comments

@AnnaShaleva
Copy link
Member

Current Behavior

traverseiterator RPC server test is failing if running on newly-generated basic chain:

        logger.go:146: 2024-11-11T13:54:34.933+0300	DEBUG	processing rpc request	{"method": "invokefunction", "params": "[2e0809e43dc0f81dab1b48e45dccbc1148ee2a2e iterateOverValues]"}
        logger.go:146: 2024-11-11T13:54:34.934+0300	DEBUG	processing rpc request	{"method": "traverseiterator", "params": "[00613c57-4ddb-4695-b1f1-636bc211e704 e21bf375-53c7-4f9c-b61f-a345187188b5 1]"}
        logger.go:146: 2024-11-11T13:54:34.934+0300	INFO	Error encountered with rpc request	{"code": -108, "method": "traverseiterator", "params": "[00613c57-4ddb-4695-b1f1-636bc211e704 e21bf375-53c7-4f9c-b61f-a345187188b5 1]"}
        --- FAIL: TestRPC/websocket/traverseiterator (0.01s)
            --- FAIL: TestRPC/websocket/traverseiterator/good (0.00s)
                server_test.go:3071: 
                    	Error Trace:	/home/anna/Documents/GitProjects/nspcc-dev/neo-go/pkg/services/rpcsrv/server_test.go:3071
                    	Error:      	Not equal: 
                    	            	expected: 99
                    	            	actual  : 2
                    	Test:       	TestRPC/websocket/traverseiterator/good

The test passes on the old dump of basic chain.

Expected Behavior

Test should pass.

Steps to Reproduce

  1. Regenerate basic chain with saveChain = true using TestCreateBasicChain.
  2. Update related constants (testContractHash, deploymentTxHash and etc.) in pkg/services/rpcsrv/server_test.go.
  3. Run make test, check the result.

Context

Discovered by @AliceInHunterland in #3560 (comment).

Regression

Basic chain wasn't regenerated for a long time. It's possible that we've changed something on the RPC server side or on the core side that affected SC iterator traversal process.

Your Environment

  • Version of the product used: current master (66fbcb2).
@AnnaShaleva AnnaShaleva added bug Something isn't working test Unit tests U2 Seriously planned S4 Routine I4 No visible changes labels Nov 11, 2024
@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone Nov 11, 2024
AliceInHunterland added a commit that referenced this issue Nov 14, 2024
Reverting 1b83dc2, because ranging over integers is mot supported by
smart contract compiler, ref. #3525.

Close #3671

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 14, 2024
Reverting 1b83dc2, because ranging over integers is not supported by
smart contract compiler, ref. #3525.

Close #3671

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 14, 2024
Reverting a part of 1b83dc2, because ranging over integers is not
supported by smart contract compiler, ref. #3525.

Close #3671

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 14, 2024
Reverting a part of 1b83dc2, because ranging over integers is not
supported by smart contract compiler, ref. #3525.

Close #3671

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes S4 Routine test Unit tests U2 Seriously planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant