basicchain: use UnitTestNet default config for generation #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests should use embed config too. Signed-off-by: Ekaterina Pavlova <[email protected]>
Close #3681 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
changed the title
| @@ -272,7 +272,7 @@ func TestBlockchain_StartFromExistingDB(t *testing.T) { | |||
|
|
|||
| _, _, _, err = chain.NewMultiWithCustomConfigAndStoreNoCheck(t, customConfig, cache) | |||
| require.Error(t, err) | |||
| require.True(t, strings.Contains(err.Error(), fmt.Sprintf("native %s: version mismatch for the latest hardfork Echidna (stored contract state differs from autogenerated one)", nativenames.CryptoLib)), err) | |||
| require.True(t, strings.Contains(err.Error(), fmt.Sprintf("native %s: version mismatch for the latest hardfork Default (stored contract state differs from autogenerated one)", nativenames.CryptoLib)), err) | |||
There was a problem hiding this comment.
@AnnaShaleva it could be correct?
There was a problem hiding this comment.
Yes, it's because you changed the node's fork scheduler.
AnnaShaleva
reviewed
Nov 22, 2024
| require.True(t, ok) | ||
|
|
||
| assert.ElementsMatch(t, expected, *actual) | ||
| }, |
There was a problem hiding this comment.
Useless change. And BTW, create an issue to enable this test, preview3 has passed long ago.
| ValidatorsCount: 4, | ||
| VerifyTransactions: true, | ||
| }, | ||
| cfg, err := config.Load(config.DefaultConfigPath, netmode.UnitTestNet) |
There was a problem hiding this comment.
It's not clear from the commit message what is the reason of the problem and why does this change solve it.
| @@ -272,7 +272,7 @@ func TestBlockchain_StartFromExistingDB(t *testing.T) { | |||
|
|
|||
| _, _, _, err = chain.NewMultiWithCustomConfigAndStoreNoCheck(t, customConfig, cache) | |||
| require.Error(t, err) | |||
| require.True(t, strings.Contains(err.Error(), fmt.Sprintf("native %s: version mismatch for the latest hardfork Echidna (stored contract state differs from autogenerated one)", nativenames.CryptoLib)), err) | |||
| require.True(t, strings.Contains(err.Error(), fmt.Sprintf("native %s: version mismatch for the latest hardfork Default (stored contract state differs from autogenerated one)", nativenames.CryptoLib)), err) | |||
There was a problem hiding this comment.
Yes, it's because you changed the node's fork scheduler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests failing.
Close #3681