Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: forbid https -> http Oracle request auto-redirect #2389

Merged
merged 1 commit into from
May 11, 2022

Conversation

AnnaShaleva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2389 (d88ca10) into master (48ee33f) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2389      +/-   ##
==========================================
- Coverage   85.10%   85.07%   -0.03%     
==========================================
  Files         291      291              
  Lines       36804    36808       +4     
==========================================
- Hits        31321    31314       -7     
- Misses       4171     4180       +9     
- Partials     1312     1314       +2     
Impacted Files Coverage Δ
pkg/rpc/response/result/version.go 87.14% <ø> (ø)
pkg/services/oracle/network.go 70.96% <0.00%> (-4.90%) ⬇️
pkg/network/payload/mptdata.go 81.25% <0.00%> (-18.75%) ⬇️
pkg/network/compress.go 64.00% <0.00%> (-12.00%) ⬇️
pkg/network/server.go 74.11% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d158811...d88ca10. Read the comment docs.

pkg/services/oracle/network.go Outdated Show resolved Hide resolved
pkg/services/oracle/network.go Show resolved Hide resolved
@AnnaShaleva AnnaShaleva marked this pull request as draft March 9, 2022 15:46
@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented Mar 9, 2022

Waiting for the reference fix of neo-project/neo-modules#692 (comment).

@roman-khimov roman-khimov added this to the v0.99.0 milestone Mar 21, 2022
@roman-khimov roman-khimov removed this from the v0.99.0 milestone Apr 8, 2022
@roman-khimov
Copy link
Member

Anything useful left here (http/https maybe)?

@AnnaShaleva AnnaShaleva changed the title services: adjust Oracle auto-redirect behaviour services: forbid https -> http Oracle request auto-redirect May 11, 2022
@AnnaShaleva AnnaShaleva marked this pull request as ready for review May 11, 2022 04:35
@roman-khimov roman-khimov added this to the v0.99.0 milestone May 11, 2022
@roman-khimov roman-khimov merged commit f3802c3 into master May 11, 2022
@roman-khimov roman-khimov deleted the oracle/auto-redirect branch May 11, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants