SN starts refusing to save some objects after MaxObjectSize increase
#2910
Labels
bug
Something isn't working
I4
No visible changes
neofs-storage
Storage node application issues
S4
Routine
U2
Seriously planned
Milestone
Comments
cthulhu-rider
added
bug
cthulhu-rider
added a commit
that referenced
this issue
Aug 8, 2024
Since storage node serves `ObjectService.Replicate` RPC, the gRPC server must be able to accept the biggest allowed object. Previously, node calculated global message limit for the gRPC server once on startup. With this behavior, when network setting `MaxObjectSize` was increased, the node stopped accepting write objects larger than the previous limit. This manifested itself in a denial of replication service. From now storage node updates max received gRPC message size (if needed) on each refresh of the `MaxObjectSize` setting cache and via Netmap contract's polling done once per minute. Refs #2910. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
that referenced
this issue
Aug 8, 2024
Since storage node serves `ObjectService.Replicate` RPC, the gRPC server must be able to accept the biggest allowed object. Previously, node calculated global message limit for the gRPC server once on startup. With this behavior, when network setting `MaxObjectSize` was increased, the node stopped accepting write objects larger than the previous limit. This manifested itself in a denial of replication service. From now storage node updates max received gRPC message size (if needed) on each refresh of the `MaxObjectSize` setting cache and via Netmap contract's polling done once per minute. Refs #2910. Signed-off-by: Leonard Lyubich <[email protected]>
|
Please upstream your grpc changes and let's see how it goes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MaxObjectSizenetwork setting limits payload size of physically stored NeoFS objects. Storage nodes deny bigger objects. By default, value is64M. It may be increased by the IRExpected Behavior
objects not bigger than the current setting are always accepted
Current Behavior
objects with payload bigger than the starttime limit are denied after config increase in runtime
Possible Solution
listen to net config changes and tune server according to it
Steps to Reproduce (for bugs)
see test. Briefly:
L1 = 64Mobject payload limitL2 > L1> L1Context
neofs-node/cmd/neofs-node/grpc.go
Lines 60 to 61 in 450c4e5
Regression
no
Your Environment
[email protected]The text was updated successfully, but these errors were encountered: