Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool Close() should return error for compatibility with Client #642

Open
AliceInHunterland opened this issue Nov 28, 2024 · 1 comment
Open
Labels
enhancement Improving existing functionality I3 Minimal impact pool Issue related to the pool S3 Minimally significant U2 Seriously planned
Milestone

Comments

@AliceInHunterland
Copy link

Is your feature request related to a problem? Please describe.

I'm always frustrated when I need to write additional wrappers. I want to have the pool's interface unified with the client's interface so no need to make wrappers like nspcc-dev/neo-go#3706 (comment).

Describe the solution you'd like

I'd like a returned error func (p *Pool) Close() error, similarly to func (c *Client) Close() error .

Describe alternatives you've considered

Additional context

Using SDK with both a pool and a single client.

@AliceInHunterland AliceInHunterland added U4 Nothing urgent S4 Routine I2 Regular impact feature Completely new functionality labels Nov 28, 2024
@roman-khimov
Copy link
Member

Unexpected. They're the same for real operations, but this one can also be a problem for pool users.

@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Nov 28, 2024
@roman-khimov roman-khimov added enhancement Improving existing functionality pool Issue related to the pool U2 Seriously planned I3 Minimal impact S3 Minimally significant and removed feature Completely new functionality U4 Nothing urgent I2 Regular impact S4 Routine labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact pool Issue related to the pool S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants