Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail fast in case of unexpected anwer from grpc #647

Open
532910 opened this issue Dec 5, 2024 · 1 comment
Open

fail fast in case of unexpected anwer from grpc #647

532910 opened this issue Dec 5, 2024 · 1 comment
Labels
bug Something isn't working I3 Minimal impact S4 Routine U3 Regular
Milestone
v1.0.0-rc13

Comments

@532910
Copy link

532910 commented Dec 5, 2024

See nspcc-dev/neo-go#3721 for details.

Just like the response for curl http://st1.storage.fs.neo.org:443 is pretty instantaneous, neofs should fail fast in case of unexpected response.
@532910 532910 added bug Something isn't working U2 Seriously planned labels Dec 5, 2024
@cthulhu-rider
Copy link
Contributor

caused by

neofs-sdk-go/client/client.go

Line 181 in 591dd25

grpc.FailOnNonTempDialError(true),
gRPC dial option which:

  • enables blocking until READY conn state (desired)
  • makes dial to fail immediately on any non-temporary error
    but the mentioned error is not temporary according to current gRPC implementation

to solve, we'd need to configure dialer more specifically

@roman-khimov roman-khimov added U3 Regular S4 Routine I3 Minimal impact and removed U2 Seriously planned labels Dec 5, 2024
@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I3 Minimal impact S4 Routine U3 Regular
Projects
None yet
Milestone
v1.0.0-rc13
Development

No branches or pull requests
3 participants
@532910 @roman-khimov @cthulhu-rider