Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Status responses with unknown code are not apistatus.Error #648

Open
cthulhu-rider opened this issue Dec 5, 2024 · 1 comment
Open
Labels
bug Something isn't working client Issue related to the client I3 Minimal impact S3 Minimally significant U2 Seriously planned
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

any non-zero status sent by the server must be apistatus.Error. But currently https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go/client/status#UnrecognizedStatusV2 is not. I find this incorrect

maybe

Steps to Reproduce

func TestUnrecognizedStatus(t *testing.T) {
	require.ErrorIs(t, apistatus.ErrUnrecognizedStatusV2, apistatus.Error)
}

Current Behavior

FAIL

Expected Behavior

PASS

Possible Solution

make it work

Context

Client testing

Regression

no, it is so from the apistatus.Error appearance fc0bd12. Mb @smallhive will remind why

Your Environment

@cthulhu-rider cthulhu-rider added bug Something isn't working client Issue related to the client labels Dec 5, 2024
@roman-khimov roman-khimov added U2 Seriously planned S3 Minimally significant I3 Minimal impact labels Dec 5, 2024
@roman-khimov
Copy link
Member

I don't think there is any real reason for that, just an omission.

@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client I3 Minimal impact S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants