Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: object PUT stream handler misses unexpected OK response #649

Open
cthulhu-rider opened this issue Dec 5, 2024 · 0 comments
Open
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U3 Regular

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 5, 2024

objects are put via gRPC client stream. Normally the server should respond with OK only after the stream is finished by the client (via Close)

Current Behavior

Write misses the unexpected OK response, and if user calls Write again, he receives following error:

rpc error: code = Internal desc = SendMsg called after CloseSend

This is a gRPC error when trying to send a message to a closed stream (what shouldn't happen)

Expected Behavior

when stream finish encountered, and the code is OK, return

server unexpectedly interrupted the stream with status OK

Possible Solution

x.err = x.client.processResponse(&respV2)

x.err will be nil here. If so, return a stream violation error

Context

Client testing

Regression

No

Your Environment

@cthulhu-rider cthulhu-rider added bug Something isn't working U2 Seriously planned client Issue related to the client and removed U2 Seriously planned labels Dec 5, 2024
@roman-khimov roman-khimov added U3 Regular S4 Routine I4 No visible changes labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants