Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Prohibit empty chunk responses for GET/RANGE/SEARCH #651

Open
cthulhu-rider opened this issue Dec 6, 2024 · 0 comments
Open

client: Prohibit empty chunk responses for GET/RANGE/SEARCH #651

cthulhu-rider opened this issue Dec 6, 2024 · 0 comments
Labels
client Issue related to the client enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 6, 2024

Is your feature request related to a problem? Please describe.

currently, Client does not consider empty chunk responses (*) with OK status invalid. At the same time, now this can only signal a buggy server: an empty message loads the network, + cryptography, and carries nothing. Being transmitted, they are silently reducing system performance

(*) note that SEARCH stream with a single empty message is valid cuz it means not found

if server will start spamming empty chunks for whatever reason, the Client will hang doing a lot of useless work. The only savior will be the context deadline (if set)

Describe the solution you'd like

prohibit empty data chunks, react with corresponding error

Describe alternatives you've considered

try to find potential benefits in them. I see no

Additional context

Client testing

@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality client Issue related to the client discussion Open discussion of some problem labels Dec 6, 2024
@roman-khimov roman-khimov added U4 Nothing urgent S3 Minimally significant I3 Minimal impact and removed discussion Open discussion of some problem labels Dec 9, 2024
@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issue related to the client enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants