Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Get and GetRange handlers miss some invalid messages sequences #659

Open
cthulhu-rider opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working client Issue related to the client

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 10, 2024

Get(Range) response payload is defined as oneof, but messages must be streamed in a strict order:

  • all messages with chunk or
  • exactly one message with split_info field

Current Behavior

  1. split_info after chunk -> split info error (Range)
  2. chunk after split_info -> split info error

Expected Behavior

  1. unexpected message instead of chunk part: *object.SplitInfo error
  2. unexpected message after split info response error

Steps to Reproduce

Regression

no

Your Environment

  • Version of the product used: 335d9fe
@cthulhu-rider cthulhu-rider added bug Something isn't working client Issue related to the client labels Dec 10, 2024
@cthulhu-rider cthulhu-rider changed the title client: GetRange handler misses some invalid messages sequences client: Get and GetRange handlers miss some invalid messages sequences Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client
Projects
None yet
Development

No branches or pull requests

1 participant