Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Clarify error reason when required response body is missing #660

Open
cthulhu-rider opened this issue Dec 10, 2024 · 0 comments
Open
Labels
client Issue related to the client enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

Is your feature request related to a problem? Please describe.

all response payloads are transmitted in the body field. In most cases ay least one body field is required. When the body is missing in the response, client returns missing X field in the response where X is the 1st required field being checked

overall, this is correct: error returns, and field absence follows from the body absence. But these cases are different from the protobuf pov, i'd separate them from each other. This can simplify debug

Describe the solution you'd like

return errors.New("missing body in the response")

Additional context

Client testing

@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality client Issue related to the client labels Dec 10, 2024
@roman-khimov roman-khimov added U4 Nothing urgent S3 Minimally significant I3 Minimal impact labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Issue related to the client enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants